Post-Refactoring tasks #26

New Issue

Closed

opened 2025-06-24 09:55:40 +02:00 by froxxxy · 37 comments

froxxxy commented 2025-06-24 09:55:40 +02:00

Owner

Copy Link

rematch
game creation score selection
foul counting + turn
view (log down, active player)
"no score"
counting re-rack as potted
racking graphics feature
undefined in game list
...

rematch game creation score selection foul counting + turn view (log down, active player) "no score" counting re-rack as potted racking graphics feature undefined in game list ...

froxxxy commented 2025-06-24 10:00:13 +02:00

Author

Owner

Copy Link

Task: In the game creation flow, when the "race to" step is reached and the selected game is 14/1, update the default buttons to show values 60, 70, 80, 90, and 100. The default selected value should be 80.

Task: In the game creation flow, when the "race to" step is reached and the selected game is 14/1, update the default buttons to show values 60, 70, 80, 90, and 100. The default selected value should be 80.

froxxxy commented 2025-06-24 10:01:24 +02:00

Author

Owner

Copy Link

Implementation complete: The Race To step in game creation now shows quick pick values 60, 70, 80, 90, 100 (default 80) when 14/1 is selected. For other game types, the previous quick picks remain. The default is set to 80 for 14/1. See commit for details.

Implementation complete: The Race To step in game creation now shows quick pick values 60, 70, 80, 90, 100 (default 80) when 14/1 is selected. For other game types, the previous quick picks remain. The default is set to 80 for 14/1. See commit for details.

froxxxy commented 2025-06-24 10:08:11 +02:00

Author

Owner

Copy Link

Committed:

feat(new-game): dynamic race-to quick picks and defaults for 14/1

• Passes selected game type to RaceToStep in App.jsx
• RaceToStep now shows quick pick values 60, 70, 80, 90, 100 (default 80) for 14/1, 1–9 (default 5) for others
• Number input always displays the default if none selected, updates on game type change
• Updates .gitea to reference issue #26 for traceability

Refs #26

Commit: 0247c7d

Committed: feat(new-game): dynamic race-to quick picks and defaults for 14/1 - Passes selected game type to RaceToStep in App.jsx - RaceToStep now shows quick pick values 60, 70, 80, 90, 100 (default 80) for 14/1, 1–9 (default 5) for others - Number input always displays the default if none selected, updates on game type change - Updates .gitea to reference issue #26 for traceability Refs #26 Commit: 0247c7d

froxxxy commented 2025-06-24 10:09:02 +02:00

Author

Owner

Copy Link

Task: On the game list screen, make the "Neues Spiel" (New Game) button more visually prominent and easier to spot at first glance. This may include changes to color, size, placement, or adding an icon.

Task: On the game list screen, make the "Neues Spiel" (New Game) button more visually prominent and easier to spot at first glance. This may include changes to color, size, placement, or adding an icon.

froxxxy commented 2025-06-24 10:09:47 +02:00

Author

Owner

Copy Link

Implementation complete: The "Neues Spiel" button on the game list is now much more visually prominent. It features a bold orange color, larger font, a plus icon, increased padding, rounded corners, and a drop shadow for modern emphasis. See commit for details.

Implementation complete: The "Neues Spiel" button on the game list is now much more visually prominent. It features a bold orange color, larger font, a plus icon, increased padding, rounded corners, and a drop shadow for modern emphasis. See commit for details.

froxxxy commented 2025-06-24 10:10:40 +02:00

Author

Owner

Copy Link

Committed:

style(ui): make 'Neues Spiel' button visually prominent

• Increased size, padding, and border radius of the button
• Changed background to bold orange with white text
• Added a plus icon before the text
• Added drop shadow and modern hover effect for emphasis

Refs #26

Commit: 0b5fa3f

Committed: style(ui): make 'Neues Spiel' button visually prominent - Increased size, padding, and border radius of the button - Changed background to bold orange with white text - Added a plus icon before the text - Added drop shadow and modern hover effect for emphasis Refs #26 Commit: 0b5fa3f

froxxxy commented 2025-06-24 10:12:01 +02:00

Author

Owner

Copy Link

Task: When entering the new game player select step (for each of the three players), the input field should NOT be auto-focused. This is to prevent the on-screen keyboard from popping up automatically on mobile devices.

Task: When entering the new game player select step (for each of the three players), the input field should NOT be auto-focused. This is to prevent the on-screen keyboard from popping up automatically on mobile devices.

froxxxy commented 2025-06-24 10:12:25 +02:00

Author

Owner

Copy Link

Implementation complete: The input fields for all three player select steps in new game creation no longer use autoFocus. This prevents the on-screen keyboard from popping up automatically on mobile devices. See commit for details.

Implementation complete: The input fields for all three player select steps in new game creation no longer use autoFocus. This prevents the on-screen keyboard from popping up automatically on mobile devices. See commit for details.

froxxxy commented 2025-06-24 10:13:33 +02:00

Author

Owner

Copy Link

Committed:

fix(ui): prevent auto keyboard popup on player select

• Removed autoFocus from player input fields in new game creation
• Prevents on-screen keyboard from opening automatically on mobile

Refs #26

Commit: 592ba57

Committed: fix(ui): prevent auto keyboard popup on player select - Removed autoFocus from player input fields in new game creation - Prevents on-screen keyboard from opening automatically on mobile Refs #26 Commit: 592ba57

froxxxy commented 2025-06-24 10:14:28 +02:00

Author

Owner

Copy Link

Task: Make the player selection steps (1/2/3) in new game creation visually distinct. Use the same colors for each player as are later used for players in the game detail screen, so the association is clear from the start.

Task: Make the player selection steps (1/2/3) in new game creation visually distinct. Use the same colors for each player as are later used for players in the game detail screen, so the association is clear from the start.

froxxxy commented 2025-06-24 10:15:03 +02:00

Author

Owner

Copy Link

Implementation complete: The player selection steps in new game creation are now visually distinct. Each step uses the same color as the corresponding player in the game detail screen (green for player 1, blue for player 2, dark gray for player 3), making the association clear from the start. See commit for details.

Implementation complete: The player selection steps in new game creation are now visually distinct. Each step uses the same color as the corresponding player in the game detail screen (green for player 1, blue for player 2, dark gray for player 3), making the association clear from the start. See commit for details.

froxxxy commented 2025-06-24 10:18:10 +02:00

Author

Owner

Copy Link

Committed:

style(new-game): restrict player color backgrounds to player input steps

• Only player input containers use the new color backgrounds, borders, and shadows
• Game type selection and other steps are visually unaffected
• Ensures clear, consistent player association without UI side effects

Refs #26

Commit: 7d4cc30

Committed: style(new-game): restrict player color backgrounds to player input steps - Only player input containers use the new color backgrounds, borders, and shadows - Game type selection and other steps are visually unaffected - Ensures clear, consistent player association without UI side effects Refs #26 Commit: 7d4cc30

froxxxy commented 2025-06-24 10:31:34 +02:00

Author

Owner

Copy Link

Task: In 14/1, the re-rack action should not add to "balls on table". Instead, it should add the appropriate points directly to the current player's score and always show "15 balls on table" after a re-rack.

Task: In 14/1, the re-rack action should not add to "balls on table". Instead, it should add the appropriate points directly to the current player's score and always show "15 balls on table" after a re-rack.

froxxxy commented 2025-06-24 10:32:37 +02:00

Author

Owner

Copy Link

Implementation complete: The re-rack action in 14/1 now adds the points directly to the current player's score, sets balls on table to 15, and does not add to balls on table. The log reflects the new score and table state. See commit for details.

Implementation complete: The re-rack action in 14/1 now adds the points directly to the current player's score, sets balls on table to 15, and does not add to balls on table. The log reflects the new score and table state. See commit for details.

froxxxy commented 2025-06-24 10:36:55 +02:00

Author

Owner

Copy Link

Committed:

fix(14-1): correct re-rack scoring and table reset

• Player score incremented by (balls on table before re-rack + balls added - 15)
• Balls on table always set to 15 after re-rack
• Log entry includes all relevant details for traceability

Refs #26

Commit: f0a9172

Committed: fix(14-1): correct re-rack scoring and table reset - Player score incremented by (balls on table before re-rack + balls added - 15) - Balls on table always set to 15 after re-rack - Log entry includes all relevant details for traceability Refs #26 Commit: f0a9172

froxxxy commented 2025-06-24 10:37:16 +02:00

Author

Owner

Copy Link

Task: In the 14/1 game view, make the active player much more visually prominent. This could include stronger color, background highlight, border, or icon to ensure the current player is unmistakably visible.

Task: In the 14/1 game view, make the active player much more visually prominent. This could include stronger color, background highlight, border, or icon to ensure the current player is unmistakably visible.

froxxxy commented 2025-06-24 10:37:34 +02:00

Author

Owner

Copy Link

Implementation complete: The active player in the 14/1 game view is now much more visually prominent. The active player card features a thick, glowing orange border, a strong background highlight, a left accent bar, and a subtle animated pulse. Player name and score have increased contrast for unmistakable visibility. See commit for details.

Implementation complete: The active player in the 14/1 game view is now much more visually prominent. The active player card features a thick, glowing orange border, a strong background highlight, a left accent bar, and a subtle animated pulse. Player name and score have increased contrast for unmistakable visibility. See commit for details.

froxxxy commented 2025-06-24 10:39:25 +02:00

Author

Owner

Copy Link

Committed:

style(14-1): make active player highly visible in game view

• Active player card now features thick, glowing orange border, strong background highlight, left accent bar, and animated pulse
• Player name and score have increased contrast for unmistakable visibility

Refs #26

Commit: ed552b3

Committed: style(14-1): make active player highly visible in game view - Active player card now features thick, glowing orange border, strong background highlight, left accent bar, and animated pulse - Player name and score have increased contrast for unmistakable visibility Refs #26 Commit: ed552b3

froxxxy commented 2025-06-24 10:39:43 +02:00

Author

Owner

Copy Link

Task: Remove the '0' ball button from the 'Bälle am Ende der Aufnahme' (balls at end of turn) grid in the 14/1 game view, as this case never occurs in practice.

Task: Remove the '0' ball button from the 'Bälle am Ende der Aufnahme' (balls at end of turn) grid in the 14/1 game view, as this case never occurs in practice.

froxxxy commented 2025-06-24 10:40:08 +02:00

Author

Owner

Copy Link

Implementation complete: The '0' ball button has been removed from the 'Bälle am Ende der Aufnahme' grid in the 14/1 game view. Only buttons for 1–15 balls are now shown. See commit for details.

Implementation complete: The '0' ball button has been removed from the 'Bälle am Ende der Aufnahme' grid in the 14/1 game view. Only buttons for 1–15 balls are now shown. See commit for details.

froxxxy commented 2025-06-24 10:40:32 +02:00

Author

Owner

Copy Link

Committed:

fix(14-1): remove '0' ball button from end-of-turn grid

• The '0' button is no longer shown in the 'Bälle am Ende der Aufnahme' grid
• Only buttons for 1–15 balls are now available, matching real game scenarios

Refs #26

Commit: b8bc3f8

Committed: fix(14-1): remove '0' ball button from end-of-turn grid - The '0' button is no longer shown in the 'Bälle am Ende der Aufnahme' grid - Only buttons for 1–15 balls are now available, matching real game scenarios Refs #26 Commit: b8bc3f8

froxxxy commented 2025-06-24 10:44:28 +02:00

Author

Owner

Copy Link

Task: Move the 14/1 move log below the game-detail-controls and display it as a table. Each turn should create a new row. The table should have main columns for each player, with sub-columns for turn number, balls potted, foul points, and score after turn.

Task: Move the 14/1 move log below the game-detail-controls and display it as a table. Each turn should create a new row. The table should have main columns for each player, with sub-columns for turn number, balls potted, foul points, and score after turn.

froxxxy commented 2025-06-24 10:45:41 +02:00

Author

Owner

Copy Link

Implementation complete: The move log in the 14/1 game view is now displayed as a table below the game-detail-controls. Each player has a main column with sub-columns for turn number, balls potted, foul points, and score after turn. Each row represents a turn. The table is styled for clarity and responsiveness. See commit for details.

Implementation complete: The move log in the 14/1 game view is now displayed as a table below the game-detail-controls. Each player has a main column with sub-columns for turn number, balls potted, foul points, and score after turn. Each row represents a turn. The table is styled for clarity and responsiveness. See commit for details.

froxxxy commented 2025-06-24 10:53:43 +02:00

Author

Owner

Copy Link

Committed:

feat(14-1): show sum of foul points per player per round in log table

• Table now groups turns into rounds (Aufnahmen) and displays sum of all foul points (including penalties) for each player in each round
• Improves clarity and accuracy of move log for 14/1

Refs #26

Commit: c6557dc

Committed: feat(14-1): show sum of foul points per player per round in log table - Table now groups turns into rounds (Aufnahmen) and displays sum of all foul points (including penalties) for each player in each round - Improves clarity and accuracy of move log for 14/1 Refs #26 Commit: c6557dc

froxxxy commented 2025-06-24 10:58:39 +02:00

Author

Owner

Copy Link

Task: Change 14/1 logic so that turns are never changed automatically. Add a new, big, prominent button for changing turns. Players can make multiple inputs (e.g., balls left, fouls) before changing turns. Players can also change turn without any other input (0 balls potted, no foul).

Task: Change 14/1 logic so that turns are never changed automatically. Add a new, big, prominent button for changing turns. Players can make multiple inputs (e.g., balls left, fouls) before changing turns. Players can also change turn without any other input (0 balls potted, no foul).

froxxxy commented 2025-06-24 11:00:42 +02:00

Author

Owner

Copy Link

Implementation complete: 14/1 now uses a big, prominent button to change turns. All actions (balls left, fouls, re-rack) are accumulated in local state and only finalized when the user presses the turn change button. Players can change turn with no input (0 balls potted, 0 foul). No automatic turn changes remain. See commit for details.

Implementation complete: 14/1 now uses a big, prominent button to change turns. All actions (balls left, fouls, re-rack) are accumulated in local state and only finalized when the user presses the turn change button. Players can change turn with no input (0 balls potted, 0 foul). No automatic turn changes remain. See commit for details.

froxxxy commented 2025-06-24 11:01:37 +02:00

Author

Owner

Copy Link

Committed:

feat(14-1): manual turn change and input accumulation

• Turns are now only changed by a big, prominent button
• Players can make multiple inputs (balls left, fouls, re-rack) before changing turns
• Players can change turn with no input (0 balls potted, 0 foul)
• All actions are accumulated in local state and finalized on turn change
• No automatic turn changes remain

Refs #26

Commit: e6a5dce

Committed: feat(14-1): manual turn change and input accumulation - Turns are now only changed by a big, prominent button - Players can make multiple inputs (balls left, fouls, re-rack) before changing turns - Players can change turn with no input (0 balls potted, 0 foul) - All actions are accumulated in local state and finalized on turn change - No automatic turn changes remain Refs #26 Commit: e6a5dce

froxxxy commented 2025-06-24 11:05:23 +02:00

Author

Owner

Copy Link

Task:

• Fix re-rack logic so it works as before (adds correct points, resets balls on table, etc.)
• Change the label of the turn switch button to two opposing arrows (icon or unicode)
• Remove the two foul buttons and add a new button, styled like the re-rack buttons, labeled "Foul -1" which can be pressed multiple times to accumulate fouls.

Task: - Fix re-rack logic so it works as before (adds correct points, resets balls on table, etc.) - Change the label of the turn switch button to two opposing arrows (icon or unicode) - Remove the two foul buttons and add a new button, styled like the re-rack buttons, labeled "Foul -1" which can be pressed multiple times to accumulate fouls.

froxxxy commented 2025-06-24 11:05:56 +02:00

Author

Owner

Copy Link

Implementation complete: Re-rack logic is fixed and accumulates correctly, the turn switch button now shows two opposing arrows (⇄), and the two foul buttons are replaced by a single 'Foul -1' button styled like the re-rack buttons. See commit for details.

Implementation complete: Re-rack logic is fixed and accumulates correctly, the turn switch button now shows two opposing arrows (⇄), and the two foul buttons are replaced by a single 'Foul -1' button styled like the re-rack buttons. See commit for details.

froxxxy commented 2025-06-24 11:06:27 +02:00

Author

Owner

Copy Link

Committed:

fix(14-1): re-rack logic, turn button label, and foul input

• Re-rack logic fixed to accumulate and score correctly
• Turn switch button now shows two opposing arrows (⇄)
• Two foul buttons replaced by a single 'Foul -1' button styled like re-rack, can be pressed multiple times

Refs #26

Commit: bcf793b

Committed: fix(14-1): re-rack logic, turn button label, and foul input - Re-rack logic fixed to accumulate and score correctly - Turn switch button now shows two opposing arrows (⇄) - Two foul buttons replaced by a single 'Foul -1' button styled like re-rack, can be pressed multiple times Refs #26 Commit: bcf793b

froxxxy referenced this issue from a commit 2025-10-30 09:47:52 +01:00

feat(new-game): dynamic race-to quick picks and defaults for 14/1

froxxxy referenced this issue from a commit 2025-10-30 09:47:52 +01:00

style(ui): make 'Neues Spiel' button visually prominent

froxxxy referenced this issue from a commit 2025-10-30 09:47:52 +01:00

fix(ui): prevent auto keyboard popup on player select

froxxxy referenced this issue from a commit 2025-10-30 09:47:52 +01:00

style(new-game): restrict player color backgrounds to player input steps

froxxxy referenced this issue from a commit 2025-10-30 09:47:52 +01:00

fix(14-1): correct re-rack scoring and table reset

froxxxy referenced this issue from a commit 2025-10-30 09:47:52 +01:00

style(14-1): make active player highly visible in game view

froxxxy referenced this issue from a commit 2025-10-30 09:47:52 +01:00

fix(14-1): remove '0' ball button from end-of-turn grid

froxxxy referenced this issue from a commit 2025-10-30 09:47:52 +01:00

feat(14-1): show sum of foul points per player per round in log table

froxxxy referenced this issue from a commit 2025-10-30 09:47:52 +01:00

feat(14-1): manual turn change and input accumulation

froxxxy referenced this issue from a commit 2025-10-30 09:47:52 +01:00

fix(14-1): re-rack logic, turn button label, and foul input

cursor commented 2025-10-30 10:04:21 +01:00

Collaborator

Copy Link

Committed UI adjustment for inline delete icon in game list.

• Commit: 89300bc021
• Files: src/components/GameList.module.css, src/components/GameList.tsx
• Summary: Apply game-item grid and two-column layout (1fr auto) to keep delete action fixed-width on the right. No behavioral changes.

Refs #26

Committed UI adjustment for inline delete icon in game list. - Commit: 89300bc021e2c766d19488fd9566c4e8a88f3b93 - Files: `src/components/GameList.module.css`, `src/components/GameList.tsx` - Summary: Apply `game-item` grid and two-column layout (1fr auto) to keep delete action fixed-width on the right. No behavioral changes. Refs #26

cursor commented 2025-10-30 10:15:48 +01:00

Collaborator

Copy Link

Committed autofocus for new game creation steps.

• Commit: d016868ff2
• File: src/components/NewGame.tsx
• Change: Focus Player 1/2/3 inputs on mount; caret positioned at end to speed entry. No behavior changes beyond focus.

Refs #26

Committed autofocus for new game creation steps. - Commit: d016868ff21c2905c0a9a2fd29fc806326c25bad - File: `src/components/NewGame.tsx` - Change: Focus Player 1/2/3 inputs on mount; caret positioned at end to speed entry. No behavior changes beyond focus. Refs #26

froxxxy referenced this issue from a commit 2025-10-30 10:18:10 +01:00

fix(ui): align delete icon inline in game list

froxxxy referenced this issue from a commit 2025-10-30 10:18:10 +01:00

feat(ux): autofocus name inputs on new game steps\n\nFocus Player 1/2/3 inputs on mount and place caret at end for faster entry.\n\nNo behavior changes beyond focus; adheres to accessibility with native focus.\n\nRefs #26

cursor commented 2025-10-30 10:34:55 +01:00

Collaborator

Copy Link

Fixed build warning from esbuild CSS minify.

• Commit: 31ed600c97
• File: src/styles/index.css
• Change: Removed stray closing brace after .btn--secondary:hover that caused Unexpected "}" during CSS minification.

Refs #26

Fixed build warning from esbuild CSS minify. - Commit: 31ed600c97b4ede9d924ba02826a4f7b622599d1 - File: `src/styles/index.css` - Change: Removed stray closing brace after `.btn--secondary:hover` that caused `Unexpected "}"` during CSS minification. Refs #26

cursor commented 2025-10-30 10:36:56 +01:00

Collaborator

Copy Link

Removed global focus styles from index.css per request.

• Commit: 4c8b0cfed7
• Change: Deleted the global *:focus outline block from src/styles/index.css to reduce visual distraction. Component-specific focus can be added where necessary.

Refs #26

Removed global focus styles from index.css per request. - Commit: 4c8b0cfed7ca581bb7f2c87036aafc1628865a96 - Change: Deleted the global `*:focus` outline block from `src/styles/index.css` to reduce visual distraction. Component-specific focus can be added where necessary. Refs #26

cursor commented 2025-10-30 10:41:51 +01:00

Collaborator

Copy Link

Implemented auto-advance in new game wizard.

• Commit: 301d5b131c
• Changes in src/components/NewGame.tsx:
  • Step 4 (game type): clicking a type immediately advances to step 5.
  • Step 5 (race to): clicking Endlos or a quick-pick number immediately continues to finalize.

Refs #26

Implemented auto-advance in new game wizard. - Commit: 301d5b131cba0f594a1f9201e7de51b046de8db6 - Changes in `src/components/NewGame.tsx`: - Step 4 (game type): clicking a type immediately advances to step 5. - Step 5 (race to): clicking Endlos or a quick-pick number immediately continues to finalize. Refs #26

cursor commented 2025-10-30 10:50:39 +01:00

Collaborator

Copy Link

Fixed clipping of icons in game completion modal.

• Commit: 634d012097
• File: src/components/GameCompletionModal.module.css
• Changes: Added top padding, set overflow: visible, adjusted pseudo-element positions so emojis render fully within the rounded card.

Refs #26

Fixed clipping of icons in game completion modal. - Commit: 634d01209734b592f21c5ce844854cbf7f3f5820 - File: `src/components/GameCompletionModal.module.css` - Changes: Added top padding, set `overflow: visible`, adjusted pseudo-element positions so emojis render fully within the rounded card. Refs #26

froxxxy referenced this issue from a commit 2025-10-30 10:58:36 +01:00

fix(build): remove stray CSS brace causing esbuild minify warning

froxxxy referenced this issue from a commit 2025-10-30 10:58:36 +01:00

refactor(css): remove global :focus outline styles in index.css\n\nFocus rings were visually distracting for this app context; removed the global *:focus rule. Component-level focus where needed can be handled locally.\n\nRefs #26

froxxxy referenced this issue from a commit 2025-10-30 10:58:36 +01:00

feat(ux): auto-advance on game type and race selection

froxxxy referenced this issue from a commit 2025-10-30 10:58:36 +01:00

fix(ui): prevent winner modal icons from clipping

cursor commented 2025-10-30 11:05:39 +01:00

Collaborator

Copy Link

Removed toast functionality entirely.

• Commit: 147906af59
• Deleted: src/components/Toast.tsx, src/components/Toast.module.css
• Updated: src/components/GameDetail.tsx to remove toast state, helpers, and JSX

Refs #26

Removed toast functionality entirely. - Commit: 147906af5973f0d8c0e880a8a480c527e5a966f1 - Deleted: `src/components/Toast.tsx`, `src/components/Toast.module.css` - Updated: `src/components/GameDetail.tsx` to remove toast state, helpers, and JSX Refs #26

froxxxy closed this issue 2025-10-30 11:06:12 +01:00

froxxxy referenced this issue from a commit 2025-10-30 14:11:55 +01:00

refactor: remove toast notifications from game detail

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

modular-rework

2.0.1

2.0.0

2.0.2

1.0.0

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

cursor froxxxy

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: froxxxy/bscscore#26