4 Commits
2.0.0 ... main

Author SHA1 Message Date
Frank Schwenk
01123f291d refactor: standardize new game progress ui
- introduce shared progress indicator component for wizard steps
- align layouts and button sizing across new game panels
- update feature exports to surface the new component

Refs #30
2025-11-14 11:07:26 +01:00
Frank Schwenk
8a46a8a019 refactor: extract reusable library
- move reusable domain, data, state, ui code into src/lib
- update host screens to consume new library exports
- document architecture and configure path aliases
- bump astro integration dependencies for compatibility

Refs #30
2025-11-13 10:41:55 +01:00
Frank Schwenk
99be99d120 Make game creation wizard fit viewport without scrolling
Replace scrollable form content with responsive sizing that
automatically scales elements to fit available viewport height.

CSS improvements:
- Disable scrolling: overflow-y:auto → overflow:hidden in form-content
- Implement fluid typography with clamp() for titles, labels, buttons
- Add responsive spacing using clamp() for margins and padding
- Scale progress dots from 10px-16px based on viewport height
- Reduce button dimensions (60px min-width, 36px min-height)
- Enable element shrinking with flex-shrink:1 and min-height:0

Component cleanup:
- Remove auto-focus useEffect from Player1/2/3Step components
- Prevents unwanted layout shifts on wizard mount

Benefits:
- All elements visible without scrolling
- Responsive design scales smoothly across viewport sizes
- Cleaner UX with no scrollbars in form wizard
- Better space utilization on small screens
2025-11-07 14:30:39 +01:00
Frank Schwenk
076d6ced36 Implement fixed viewport with internal scrolling
Restructure app layout to prevent whole-page scrolling. The viewport
is now locked at 100vh with overflow:hidden, and individual content
areas scroll internally.

Architecture changes:
- Lock html/body at 100% height with overflow:hidden
- Fix Layout component to 100vh, Screen to 100% height
- Enable internal scrolling for content areas with flex:1 + overflow-y:auto

New game wizard improvements:
- Split forms into three sections: form-header (fixed), form-content
  (scrollable), form-footer (fixed with arrow navigation)
- Fixes issue where many player names pushed navigation arrows off-screen
- Applied to Player1Step, Player2Step, Player3Step, GameTypeStep

Game list improvements:
- Filter buttons stay fixed at top
- Games container scrolls internally with overflow-y:auto
- "Neues Spiel" button wrapped with flex-shrink:0

Game detail improvements:
- Game controls stay visible while content scrolls

Additional changes:
- Add Playwright test artifact exclusions to .gitignore
- Add Docker build instructions to README.md
- Remove unnecessary setSelectionRange calls from player input steps

Benefits:
- No accidental page scrolling
- Cleaner mobile UX (no address bar show/hide issues)
- Navigation controls always visible
- Predictable, contained scrolling behavior
2025-11-07 14:23:03 +01:00
81 changed files with 2525 additions and 1225 deletions

5
.gitignore vendored
View File

@@ -25,3 +25,8 @@ pnpm-debug.log*
.gitea .gitea
dev/.gitea dev/.gitea
# Playwright test artifacts
playwright-report/
test-results/
playwright/.cache/

View File

@@ -14,44 +14,17 @@ A modern, responsive pool/billiards scoring application built with **Astro** and
## 🏗️ Architecture ## 🏗️ Architecture
This project has been refactored following modern software development best practices: Everything reusable now lives under `src/lib`, allowing you to embed the core experience inside another React/Preact host without the Astro shell.
### **Separation of Concerns** - **`@lib/domain`** Pure TypeScript domain model (types, constants, validation, helpers).
- **Services Layer**: Game data management and localStorage operations - **`@lib/data`** Persistence adapters and repositories (IndexedDB, migrations).
- **Custom Hooks**: Reusable state management logic - **`@lib/state`** Composable hooks that orchestrate domain + data.
- **Components**: UI components with single responsibilities - **`@lib/ui`** Stateless UI primitives with co-located CSS modules.
- **Utils**: Pure utility functions for common operations - **`@lib/features/*`** Feature bundles composing UI + state (game list, detail, lifecycle modals, new-game wizard).
### **Type Safety** The Astro `src/components` folder is now a thin host layer (screens + island bootstrap) that consumes the library.
- Full TypeScript implementation
- Comprehensive type definitions for game domain
- Type-safe component props and state management
### **Component Architecture** Detailed module docs live in `src/lib/docs/architecture.md` and the individual `README.md` files under each package.
```
src/
├── components/
│ ├── ui/ # Reusable UI components (Button, Card, Layout)
│ ├── screens/ # Screen-level components
│ └── ... # Feature-specific components
├── hooks/ # Custom React/Preact hooks
├── services/ # Business logic and data management
├── types/ # TypeScript type definitions
├── utils/ # Pure utility functions
└── styles/ # Global styles and CSS modules
```
### **State Management**
- **useGameState**: Centralized game data management
- **useNavigation**: Screen and routing state
- **useModal**: Modal state management
- **Custom hooks**: Encapsulated, reusable state logic
### **Design System**
- Consistent design tokens and CSS custom properties
- Reusable UI components with variant support
- Responsive design patterns
- Accessibility-first approach
## 🚀 Getting Started ## 🚀 Getting Started
@@ -81,6 +54,12 @@ npm run test:record # Record browser interactions with Playwright
npm run test:e2e # Run all recorded browser automation scripts npm run test:e2e # Run all recorded browser automation scripts
``` ```
### Building with Docker
```bash
# Build for production using Docker
docker run -it -v $(pwd):/app -w /app --rm node:latest npx astro build
```
## 🧪 Testing ## 🧪 Testing
The project uses **Playwright** for browser automation and recording. This allows you to record interactions once and replay them anytime, making it easy to test repetitive workflows. The project uses **Playwright** for browser automation and recording. This allows you to record interactions once and replay them anytime, making it easy to test repetitive workflows.
@@ -116,23 +95,23 @@ For detailed instructions on recording, modifying, and running scripts, see:
## 📁 Project Structure ## 📁 Project Structure
### **Core Components** ### **Core Components**
- `App.tsx` - Main application component with orchestrated state management - `src/components/App.tsx` - Astro-bound shell orchestrating library modules
- `screens/` - Screen-level components (GameList, NewGame, GameDetail) - `src/components/screens/` - Screen containers consuming `@lib/features`
- `ui/` - Reusable UI components following design system - `src/lib/` - Reusable application spine (domain/data/state/ui/features)
### **State Management** ### **State Management**
- `hooks/useGameState.ts` - Game CRUD operations and persistence - `@lib/state/useGameState` - Game CRUD operations and persistence
- `hooks/useNavigation.ts` - Application routing and screen state - `@lib/state/useNavigation` - Application routing and screen state
- `hooks/useModal.ts` - Modal state management - `@lib/state/useModal` - Modal state management helpers
### **Business Logic** ### **Business Logic**
- `services/gameService.ts` - Game creation, updates, and business rules - `@lib/data/gameService` - Game creation, updates, and persistence orchestration
- `utils/gameUtils.ts` - Game-related utility functions - `@lib/domain/gameUtils` - Game-related utility functions
- `utils/validation.ts` - Input validation and sanitization - `@lib/domain/validation` - Input validation and sanitisation
### **Type Definitions** ### **Type Definitions**
- `types/game.ts` - Game domain types - `@lib/domain/types` - Game domain types
- `types/ui.ts` - UI component types - `@lib/ui/types` - UI component types
- `types/css-modules.d.ts` - CSS modules type support - `types/css-modules.d.ts` - CSS modules type support
## 🎯 Key Improvements ## 🎯 Key Improvements

View File

@@ -1,5 +1,9 @@
// @ts-check // @ts-check
import { fileURLToPath } from 'node:url';
import { defineConfig } from 'astro/config'; import { defineConfig } from 'astro/config';
const srcDir = fileURLToPath(new URL('./src', import.meta.url));
const libDir = fileURLToPath(new URL('./src/lib', import.meta.url));
import preact from '@astrojs/preact'; import preact from '@astrojs/preact';
// https://astro.build/config // https://astro.build/config
@@ -17,6 +21,12 @@ export default defineConfig({
// Vite configuration for development // Vite configuration for development
vite: { vite: {
resolve: {
alias: {
'@': srcDir,
'@lib': libDir,
},
},
define: { define: {
'process.env.NODE_ENV': JSON.stringify(process.env.NODE_ENV), 'process.env.NODE_ENV': JSON.stringify(process.env.NODE_ENV),
}, },

1811
package-lock.json generated

File diff suppressed because it is too large Load Diff

View File

@@ -12,8 +12,8 @@
"test:replay": "playwright test" "test:replay": "playwright test"
}, },
"dependencies": { "dependencies": {
"@astrojs/preact": "^4.1.0", "@astrojs/preact": "^4.1.3",
"astro": "^5.9.0", "astro": "^5.15.5",
"preact": "^10.26.8" "preact": "^10.26.8"
}, },
"devDependencies": { "devDependencies": {

File diff suppressed because one or more lines are too long

View File

@@ -1,20 +1,24 @@
import { h } from 'preact'; import { h } from 'preact';
import { useEffect, useCallback } from 'preact/hooks'; import { useEffect, useCallback } from 'preact/hooks';
import { useGameState } from '../hooks/useGameState'; import {
import { useNavigation, useNewGameWizard } from '../hooks/useNavigation'; useGameState,
import { useModal, useValidationModal, useCompletionModal } from '../hooks/useModal'; useNavigation,
useNewGameWizard,
useModal,
useValidationModal,
useCompletionModal,
} from '@lib/state';
import { GameService } from '@lib/data/gameService';
import type { StandardGame, Game, EndlosGame } from '@lib/domain/types';
import { GameService } from '../services/gameService'; import { Layout } from '@lib/ui/Layout';
import type { StandardGame, Game, EndlosGame } from '../types/game';
import { Layout } from './ui/Layout';
import GameListScreen from './screens/GameListScreen'; import GameListScreen from './screens/GameListScreen';
import NewGameScreen from './screens/NewGameScreen'; import NewGameScreen from './screens/NewGameScreen';
import GameDetailScreen from './screens/GameDetailScreen'; import GameDetailScreen from './screens/GameDetailScreen';
import Modal from './Modal'; import Modal from '@lib/ui/Modal';
import ValidationModal from './ValidationModal'; import ValidationModal from '@lib/ui/ValidationModal';
import GameCompletionModal from './GameCompletionModal'; import GameCompletionModal from '@lib/features/game-lifecycle/GameCompletionModal';
import FullscreenToggle from './FullscreenToggle'; import FullscreenToggle from './FullscreenToggle';
/** /**

View File

@@ -10,8 +10,9 @@
<style> <style>
#app-root { #app-root {
min-height: 100vh; height: 100%;
width: 100%; width: 100%;
overflow: hidden;
} }
/* Progressive enhancement styles */ /* Progressive enhancement styles */

View File

@@ -1,7 +1,7 @@
import { h } from 'preact'; import { h } from 'preact';
import modalStyles from './Modal.module.css'; import modalStyles from '@lib/ui/Modal.module.css';
import styles from './GameCompletionModal.module.css'; import styles from './GameCompletionModal.module.css';
import type { Game } from '../types/game'; import type { Game } from '@lib/domain/types';
interface GameCompletionModalProps { interface GameCompletionModalProps {
open: boolean; open: boolean;

View File

@@ -1,7 +1,7 @@
import { h } from 'preact'; import { h } from 'preact';
import { useState } from 'preact/hooks'; import { useState } from 'preact/hooks';
import styles from './GameDetail.module.css'; import styles from './GameDetail.module.css';
import type { Game, EndlosGame } from '../types/game'; import type { Game, EndlosGame } from '@lib/domain/types';
interface GameDetailProps { interface GameDetailProps {
game: Game | undefined; game: Game | undefined;

View File

@@ -1,24 +0,0 @@
/* GameHistory-specific styles only. Shared utility classes are now in global CSS. */
.screen {
position: absolute;
top: 0;
left: 0;
width: 100%;
min-height: 100vh;
display: none;
opacity: 0;
transform: translateX(100%);
transition: transform 0.3s ease, opacity 0.3s ease;
}
.screen-content {
display: flex;
flex-direction: column;
min-height: 100vh;
padding: 20px;
overflow-y: auto;
-webkit-overflow-scrolling: touch;
}
.screen-title {
font-size: 24px;
margin-bottom: 20px;
}

View File

@@ -1,8 +1,8 @@
import { h } from 'preact'; import { h } from 'preact';
import { Card } from './ui/Card'; import { Card } from '@lib/ui/Card';
import { Button } from './ui/Button'; import { Button } from '@lib/ui/Button';
import styles from './GameList.module.css'; import styles from './GameList.module.css';
import type { Game, GameFilter, StandardGame } from '../types/game'; import type { Game, GameFilter, StandardGame } from '@lib/domain/types';
interface GameListProps { interface GameListProps {
games: Game[]; games: Game[];
@@ -56,7 +56,7 @@ export default function GameList({
]; ];
return ( return (
<div className={styles['game-list'] + ' ' + styles['games-container']}> <div className={styles['game-list']}>
<div className={styles['filter-buttons']}> <div className={styles['filter-buttons']}>
{filterButtons.map(({ key, label, ariaLabel }) => ( {filterButtons.map(({ key, label, ariaLabel }) => (
<Button <Button
@@ -71,10 +71,11 @@ export default function GameList({
))} ))}
</div> </div>
{filteredGames.length === 0 ? ( <div className={styles['games-container']}>
<div className={styles['empty-state']}>Keine Spiele vorhanden</div> {filteredGames.length === 0 ? (
) : ( <div className={styles['empty-state']}>Keine Spiele vorhanden</div>
filteredGames.map(game => { ) : (
filteredGames.map(game => {
const playerNames = getPlayerNames(game); const playerNames = getPlayerNames(game);
const scores = getScores(game); const scores = getScores(game);
@@ -121,7 +122,8 @@ export default function GameList({
</Card> </Card>
); );
}) })
)} )}
</div>
</div> </div>
); );
} }

View File

@@ -22,7 +22,7 @@ import { GameTypeStep } from './new-game/GameTypeStep';
import { RaceToStep } from './new-game/RaceToStep'; import { RaceToStep } from './new-game/RaceToStep';
import { BreakRuleStep } from './new-game/BreakRuleStep'; import { BreakRuleStep } from './new-game/BreakRuleStep';
import { BreakOrderStep } from './new-game/BreakOrderStep'; import { BreakOrderStep } from './new-game/BreakOrderStep';
import type { BreakRule } from '../types/game'; import type { BreakRule } from '@lib/domain/types';
// PlayerSelectModal moved to ./new-game/PlayerSelectModal // PlayerSelectModal moved to ./new-game/PlayerSelectModal

View File

@@ -1 +0,0 @@
import { h } from "preact";

View File

@@ -1,7 +1,7 @@
import { h } from 'preact'; import { h } from 'preact';
import { useEffect, useState } from 'preact/hooks'; import { useEffect, useState } from 'preact/hooks';
import styles from '../NewGame.module.css'; import styles from '../NewGame.module.css';
import type { BreakRule } from '../../types/game'; import type { BreakRule } from '@lib/domain/types';
interface BreakOrderStepProps { interface BreakOrderStepProps {
players: string[]; players: string[];

View File

@@ -1,7 +1,7 @@
import { h } from 'preact'; import { h } from 'preact';
import { useState } from 'preact/hooks'; import { useState } from 'preact/hooks';
import styles from '../NewGame.module.css'; import styles from '../NewGame.module.css';
import type { BreakRule } from '../../types/game'; import type { BreakRule } from '@lib/domain/types';
interface BreakRuleStepProps { interface BreakRuleStepProps {
onNext: (rule: BreakRule) => void; onNext: (rule: BreakRule) => void;

View File

@@ -1,7 +1,7 @@
import { h } from 'preact'; import { h } from 'preact';
import { Screen } from '../ui/Layout'; import { Screen } from '@lib/ui/Layout';
import GameDetail from '../GameDetail'; import GameDetail from '@lib/features/game-detail/GameDetail';
import type { Game, EndlosGame } from '../../types/game'; import type { Game, EndlosGame } from '@lib/domain/types';
interface GameDetailScreenProps { interface GameDetailScreenProps {
game?: Game; game?: Game;

View File

@@ -1,8 +1,8 @@
import { h } from 'preact'; import { h } from 'preact';
import { Button } from '../ui/Button'; import { Button } from '@lib/ui/Button';
import { Screen } from '../ui/Layout'; import { Screen } from '@lib/ui/Layout';
import GameList from '../GameList'; import GameList from '@lib/features/game-list/GameList';
import type { Game, GameFilter } from '../../types/game'; import type { Game, GameFilter } from '@lib/domain/types';
interface GameListScreenProps { interface GameListScreenProps {
games: Game[]; games: Game[];
@@ -23,15 +23,17 @@ export default function GameListScreen({
}: GameListScreenProps) { }: GameListScreenProps) {
return ( return (
<Screen> <Screen>
<Button <div style={{ flexShrink: 0 }}>
variant="primary" <Button
size="large" variant="primary"
onClick={onShowNewGame} size="large"
aria-label="Neues Spiel starten" onClick={onShowNewGame}
style={{ width: '100%', marginBottom: '24px' }} aria-label="Neues Spiel starten"
> style={{ width: '100%', marginBottom: '24px' }}
+ Neues Spiel >
</Button> + Neues Spiel
</Button>
</div>
<GameList <GameList
games={games} games={games}

View File

@@ -1,7 +1,16 @@
import { h } from 'preact'; import { h } from 'preact';
import { Screen } from '../ui/Layout'; import { Screen } from '@lib/ui/Layout';
import { Player1Step, Player2Step, Player3Step, GameTypeStep, BreakRuleStep, BreakOrderStep, RaceToStep } from '../NewGame'; import {
import type { NewGameStep, NewGameData } from '../../types/game'; Player1Step,
Player2Step,
Player3Step,
GameTypeStep,
BreakRuleStep,
BreakOrderStep,
RaceToStep,
} from '@lib/features/new-game';
import type { NewGameStep, NewGameData, GameType } from '@lib/domain/types';
import { GAME_TYPES, RACE_TO_DEFAULT } from '@lib/domain/constants';
interface NewGameScreenProps { interface NewGameScreenProps {
step: NewGameStep; step: NewGameStep;
@@ -40,9 +49,13 @@ export default function NewGameScreen({
}; };
const handleGameTypeNext = (type: string) => { const handleGameTypeNext = (type: string) => {
onDataChange({ const selectedType = type as GameType;
gameType: type as any, // Type assertion for now, could be improved with proper validation const match = GAME_TYPES.find((item) => item.value === selectedType);
raceTo: '8' const defaultRace = match ? String(match.defaultRaceTo) : String(RACE_TO_DEFAULT);
onDataChange({
gameType: selectedType,
raceTo: defaultRace,
}); });
onStepChange('raceTo'); onStepChange('raceTo');
}; };

View File

@@ -1,5 +1,5 @@
import { h } from 'preact'; import { h } from 'preact';
import type { ButtonProps } from '../../types/ui'; import type { ButtonProps } from '@lib/ui/types';
import styles from './Button.module.css'; import styles from './Button.module.css';
export function Button({ export function Button({

View File

@@ -1,6 +1,6 @@
import { useState, useEffect, useCallback } from 'preact/hooks'; import { useState, useEffect, useCallback } from 'preact/hooks';
import type { Game, NewGameData, GameFilter } from '../types/game'; import type { Game, NewGameData, GameFilter } from '@lib/domain/types';
import { GameService } from '../services/gameService'; import { GameService } from '@lib/data/gameService';
export function useGameState() { export function useGameState() {
const [games, setGames] = useState<Game[]>([]); const [games, setGames] = useState<Game[]>([]);

View File

@@ -1,6 +1,6 @@
import { useState, useCallback } from 'preact/hooks'; import { useState, useCallback } from 'preact/hooks';
import type { ModalState, ValidationState, CompletionModalState } from '../types/ui'; import type { ModalState, ValidationState, CompletionModalState } from '@lib/ui/types';
import type { Game } from '../types/game'; import type { Game } from '@lib/domain/types';
export function useModal() { export function useModal() {
const [modal, setModal] = useState<ModalState>({ open: false, gameId: null }); const [modal, setModal] = useState<ModalState>({ open: false, gameId: null });

View File

@@ -1,5 +1,5 @@
import { useState, useCallback } from 'preact/hooks'; import { useState, useCallback } from 'preact/hooks';
import type { NewGameStep, NewGameData } from '../types/game'; import type { NewGameStep, NewGameData } from '@lib/domain/types';
type Screen = 'game-list' | 'new-game' | 'game-detail'; type Screen = 'game-list' | 'new-game' | 'game-detail';

33
src/lib/data/README.md Normal file
View File

@@ -0,0 +1,33 @@
# Data Layer (`@lib/data`)
Responsible for persistence and data access abstractions. All I/O lives here.
## Modules
- `gameService.ts`
- High-level repository for CRUD operations on games.
- Bridges domain rules with `IndexedDBService`.
- Provides helpers: `loadGames`, `saveGame`, `createGame`, `updateGameScore`, `isGameCompleted`, `getGameWinner`, etc.
- `indexedDBService.ts`
- Low-level IndexedDB wrapper with schema management and convenience indices.
- Exposes granular operations (`loadGame`, `deleteGame`, `getGamesByFilter`, `updatePlayerStats`, …).
- `testing/testIndexedDB.ts`
- Browser-side harness to validate IndexedDB flows manually.
## Guidance
- Prefer calling `GameService` from UI/state hooks.
It encapsulates migration logic (localStorage fallback) and player stats updates.
- Keep new persistence concerns behind small classes or factory functions under `@lib/data`.
- When a data function starts bleeding UI concerns, move that logic upward into `@lib/state`.
## Example
```ts
import { GameService } from '@lib/data';
const games = await GameService.loadGames();
await GameService.saveGame(updatedGame);
```

View File

@@ -1,4 +1,11 @@
import type { Game, GameType, StandardGame, EndlosGame, NewGameData, BreakRule } from '../types/game'; import type {
Game,
GameType,
StandardGame,
EndlosGame,
NewGameData,
BreakRule,
} from '@lib/domain/types';
import { IndexedDBService } from './indexedDBService'; import { IndexedDBService } from './indexedDBService';
const LOCAL_STORAGE_KEY = 'bscscore_games'; const LOCAL_STORAGE_KEY = 'bscscore_games';

3
src/lib/data/index.ts Normal file
View File

@@ -0,0 +1,3 @@
export * from './gameService';
export * from './indexedDBService';

View File

@@ -1,4 +1,4 @@
import type { Game, GameType, StandardGame, EndlosGame, NewGameData } from '../types/game'; import type { Game } from '@lib/domain/types';
const DB_NAME = 'BSCScoreDB'; const DB_NAME = 'BSCScoreDB';
const DB_VERSION = 1; const DB_VERSION = 1;

View File

@@ -1,6 +1,6 @@
import { IndexedDBService } from '../services/indexedDBService'; import { IndexedDBService } from '@lib/data/indexedDBService';
import { GameService } from '../services/gameService'; import { GameService } from '@lib/data/gameService';
import type { NewGameData } from '../types/game'; import type { NewGameData } from '@lib/domain/types';
/** /**
* Test utility for IndexedDB functionality * Test utility for IndexedDB functionality

View File

@@ -0,0 +1,64 @@
# BSC Score Modular Architecture
This document captures the reusable module layout introduced in the refactor.
Everything under `src/lib` is now consumable from other React/Preact hosts without depending on the Astro shell that ships in this repository.
## Module Overview
- `@lib/domain` **Pure domain logic** (types, constants, validation helpers, formatters).
No framework dependencies, no browser APIs. Safe to re-use from Node or tests.
- `@lib/data` **Persistence services** (IndexedDB access, repository abstractions, test harness).
Wraps browser APIs and isolates side-effects away from UI/state.
- `@lib/state` **Composable hooks** that orchestrate domain + data layers.
Exported hooks expose serialisable state and imperative actions.
- `@lib/ui` **Stateless presentational primitives** (buttons, cards, layout shell, generic modals).
Ship with co-located CSS modules and type-safe props.
- `@lib/features/*` **Feature bundles** that compose UI + state to deliver end-user flows.
Current bundles:
- `game-list` (list + filter experience)
- `game-detail` (scoreboard with break tracking)
- `game-lifecycle` (completion modal + rematch workflow)
- `new-game` (wizard steps and player pickers)
## Import Surfaces
All entry points are re-exported via `@lib/index.ts`, so consumers can either:
```ts
import { GameService, useGameState, GameList } from '@lib';
```
or pick a scoped module:
```ts
import { GameService } from '@lib/data';
import { GameList } from '@lib/features/game-list';
```
## Cross-Cutting Rules
- **Domain first**: New feature logic should be expressed with domain types and helpers before touching hooks/UI.
- **One-way dependencies**:
```
domain → data → state → features → app shell
```
Lower layers must not import from higher ones.
- **CSS modules stay co-located** with the component they style. Consumers receive the compiled class names via the exported component props.
- **Documentation lives next to code**: every module has a `README.md` describing intent, public API, and integration notes.
## Migration Notes
- Legacy `src/components` now only hosts the Astro shell (`App.tsx`, `BscScoreApp.astro`, etc.).
All reusable React pieces were migrated under `src/lib`.
- Path aliases:
- `@/*` → `src/*`
- `@lib/*` → `src/lib/*`
Update your editor/tsconfig if you embed these modules elsewhere.
- Tests should import from `@lib` to avoid depending on Astro-specific wiring.
## Next Steps
- Promote more feature-level Storybook / Playwright fixtures into `src/lib/docs`.
- When adding new modules, extend `src/lib/index.ts` and document usage in the corresponding folder.

27
src/lib/domain/README.md Normal file
View File

@@ -0,0 +1,27 @@
# Domain Layer (`@lib/domain`)
Pure domain model primitives for BSC Score. Everything here is framework-agnostic and free of side effects.
## Exports
- `types.ts` canonical TypeScript shapes (`Game`, `StandardGame`, `EndlosGame`, `NewGameData`, etc.).
- `constants.ts` configuration, validation copy, UI sizing tokens.
- `validation.ts` safe helpers for validating/sanitising player & game inputs.
- `gameUtils.ts` derived state utilities (duration, winner detection, type guards).
## Usage Guidelines
- Treat the domain layer as the single source of truth for typings across the app (UI, services, tests).
- Keep functions pure and deterministic; no DOM, storage, or logging side effects beyond debug `console` statements.
- When extending the data model, update the corresponding domain `README.md` section and propagate new types through `@lib/domain/index.ts`.
## Example
```ts
import { Game, validateGameData, GAME_TYPES } from '@lib/domain';
const result = validateGameData(dataFromForm); // -> { isValid, errors }
const isEndlos = GAME_TYPES.some((type) => type.value === '8-Ball');
```

View File

@@ -1,4 +1,4 @@
import type { GameType } from '../types/game'; import type { GameType } from './types';
export const GAME_TYPES: Array<{ value: GameType; label: string; defaultRaceTo: number }> = [ export const GAME_TYPES: Array<{ value: GameType; label: string; defaultRaceTo: number }> = [
{ value: '8-Ball', label: '8-Ball', defaultRaceTo: 5 }, { value: '8-Ball', label: '8-Ball', defaultRaceTo: 5 },

View File

@@ -1,4 +1,4 @@
import type { Game, StandardGame, EndlosGame } from '../types/game'; import type { Game, StandardGame, EndlosGame } from './types';
/** /**
* Game utility functions for common operations * Game utility functions for common operations

5
src/lib/domain/index.ts Normal file
View File

@@ -0,0 +1,5 @@
export * from './types';
export * from './constants';
export * from './validation';
export * from './gameUtils';

View File

@@ -1,5 +1,5 @@
import { APP_CONFIG, VALIDATION_MESSAGES } from './constants'; import { APP_CONFIG, VALIDATION_MESSAGES } from './constants';
import type { NewGameData } from '../types/game'; import type { NewGameData } from './types';
export interface ValidationResult { export interface ValidationResult {
isValid: boolean; isValid: boolean;

View File

@@ -0,0 +1,30 @@
# Feature Bundles (`@lib/features`)
Feature directories compose domain, data, state, and UI primitives into end-user flows. Each folder exports React/Preact components that can be dropped into any host application.
## Available Features
- `game-list`
- `GameList` component that renders filters + game cards.
- `game-detail`
- `GameDetail` scoreboard with break tracking, undo triggers, and finish controls.
- `game-lifecycle`
- `GameCompletionModal` summarising winners + rematch CTA.
- `new-game`
- Wizard step components (`Player1Step`, `BreakOrderStep`, etc.) and modal pickers.
## Usage Example
```tsx
import { GameList, GameCompletionModal } from '@lib/features/game-list';
// or, via umbrella export:
import { GameDetail, GameCompletionModal } from '@lib';
```
## Conventions
- Feature components accept plain props (typically typed with `@lib/domain` types) and delegate callbacks to the consumer.
- State management lives in `@lib/state`. Features should remain stateless except for local UI state (e.g. input fields).
- Keep CSS modules inside the feature folder to avoid cross-feature leakage.

View File

@@ -19,14 +19,27 @@
.screen-content { .screen-content {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
min-height: 100vh; height: 100%;
padding: 20px; padding: 20px;
overflow-y: auto; overflow-y: auto;
overflow-x: hidden;
-webkit-overflow-scrolling: touch; -webkit-overflow-scrolling: touch;
min-height: 0;
} }
.game-detail {
display: flex;
flex-direction: column;
height: 100%;
overflow-y: auto;
overflow-x: hidden;
padding: var(--space-md);
min-height: 0;
}
.game-title { .game-title {
font-size: 24px; font-size: 24px;
color: #ccc; color: #ccc;
flex-shrink: 0;
} }
.game-header { .game-header {
display: flex; display: flex;
@@ -34,12 +47,14 @@
align-items: center; align-items: center;
margin-bottom: 20px; margin-bottom: 20px;
width: 100%; width: 100%;
flex-shrink: 0;
} }
.scores-container { .scores-container {
display: flex; display: flex;
justify-content: space-between; justify-content: space-between;
gap: 32px; gap: 32px;
min-height: 0; min-height: 0;
flex-shrink: 0;
} }
.player-score { .player-score {
flex: 1; flex: 1;
@@ -202,8 +217,10 @@
flex-direction: row; flex-direction: row;
gap: 24px; gap: 24px;
margin: 40px 0 0 0; margin: 40px 0 0 0;
padding-bottom: var(--space-xl);
width: 100%; width: 100%;
justify-content: center; justify-content: center;
flex-shrink: 0;
} }
.franky .player-name { .franky .player-name {
font-weight: bold; font-weight: bold;

View File

@@ -0,0 +1,104 @@
import { h } from 'preact';
import styles from './GameDetail.module.css';
import type { Game, EndlosGame } from '@lib/domain/types';
interface GameDetailProps {
game: Game | undefined;
onFinishGame: () => void;
onUpdateScore: (player: number, change: number) => void;
onUpdateGame?: (game: EndlosGame) => void;
onUndo?: () => void;
onForfeit?: () => void;
onBack: () => void;
}
/**
* Game detail view for a single game.
*/
const GameDetail = ({ game, onFinishGame, onUpdateScore, onUpdateGame, onUndo, onForfeit, onBack }: GameDetailProps) => {
if (!game) return null;
const handleScoreUpdate = (playerIndex: number, change: number) => {
onUpdateScore(playerIndex, change);
// Silent update; toast notifications removed
};
const isCompleted = game.status === 'completed';
const playerNames = [game.player1, game.player2, game.player3].filter(Boolean);
const scores = [game.score1, game.score2, game.score3].filter((_, i) => playerNames[i]);
return (
<div className={styles['game-detail']}>
<div className={styles['game-title']}>
{game.gameType}{game.raceTo ? ` | Race to ${game.raceTo}` : ''}
</div>
<div className={styles['scores-container']}>
{playerNames.map((name, idx) => {
const currentScore = scores[idx];
const progressPercentage = game.raceTo ? Math.min((currentScore / game.raceTo) * 100, 100) : 0;
return (
<div
className={styles['player-score'] + (name === 'Fränky' ? ' ' + styles['franky'] : '')}
key={name + idx}
>
<span className={styles['player-name']}>
{name}
{(() => {
const order = (game as any).breakOrder as number[] | undefined;
const breakerIdx = (game as any).currentBreakerIdx as number | undefined;
if (order && typeof breakerIdx === 'number' && order[breakerIdx] === idx + 1) {
return <span title="Break" aria-label="Break" style={{ display: 'inline-block', width: '1em', height: '1em', borderRadius: '50%', background: '#fff', marginLeft: 6, verticalAlign: 'middle' }} />;
}
return null;
})()}
</span>
<div className={styles['progress-bar']}>
<div
className={styles['progress-fill']}
style={{ width: `${progressPercentage}%` }}
/>
</div>
<span
className={styles['score']}
id={`score${idx + 1}`}
onClick={() => !isCompleted && onUpdateScore(idx + 1, 1)}
onKeyDown={(e) => {
if (!isCompleted && (e.key === 'Enter' || e.key === ' ')) {
e.preventDefault();
onUpdateScore(idx + 1, 1);
}
}}
role="button"
tabIndex={isCompleted ? -1 : 0}
aria-label={`Aktueller Punktestand für ${name}: ${scores[idx]}. Klicken oder Enter drücken zum Erhöhen.`}
>
{scores[idx]}
</span>
{/* +/- buttons removed per issue #29. Tap score to +1; use Undo to revert. */}
</div>
);
})}
</div>
<div className={styles['game-detail-controls']}>
<button className="btn" onClick={onBack} aria-label="Zurück zur Liste">Zurück zur Liste</button>
{onUndo && (
<button
className="btn btn--secondary"
onClick={() => {
onUndo();
}}
aria-label="Rückgängig"
>
Rückgängig
</button>
)}
<button className="btn" disabled={isCompleted} onClick={onFinishGame} aria-label={isCompleted ? 'Abgeschlossen' : 'Spiel beenden'}>{isCompleted ? 'Abgeschlossen' : 'Spiel beenden'}</button>
</div>
</div>
);
};
export default GameDetail;

View File

@@ -0,0 +1,34 @@
# Game Detail (`@lib/features/game-detail`)
`GameDetail` shows a single game's state, including live score controls and break indicators.
## Props
- `game: Game`
- `onUpdateScore(playerIndex: number, delta: number): void`
- `onFinishGame(): void`
- `onUpdateGame?(game: EndlosGame): void`
- `onUndo?(): void`
- `onForfeit?(): void`
- `onBack(): void`
## Highlights
- Handles both standard and endlos game modes.
- Displays current breaker marker based on `breakOrder` / `currentBreakerIdx`.
- Uses accessible button semantics so scores can be increased via keyboard.
## Example
```tsx
import { GameDetail } from '@lib/features/game-detail';
<GameDetail
game={selectedGame}
onUpdateScore={(player, change) => GameService.saveGame(...)}
onFinishGame={endGame}
onBack={showGameList}
/>;
```

View File

@@ -0,0 +1,2 @@
export { default as GameDetail } from './GameDetail';

View File

@@ -0,0 +1,63 @@
import { h } from 'preact';
import modalStyles from '@lib/ui/Modal.module.css';
import styles from './GameCompletionModal.module.css';
import type { Game } from '@lib/domain/types';
interface GameCompletionModalProps {
open: boolean;
game: Game | null;
onConfirm: () => void;
onClose: () => void;
onRematch: () => void;
}
/**
* Modal shown when a game is completed.
*/
const GameCompletionModal = ({ open, game, onConfirm, onClose, onRematch }: GameCompletionModalProps) => {
if (!open || !game) return null;
const playerNames = [game.player1, game.player2, game.player3].filter(Boolean);
const scores = [game.score1, game.score2, game.score3].filter((_, i) => playerNames[i]);
let maxScore, winners, winnerText;
if (game.forfeitedBy) {
winnerText = `${game.winner} hat gewonnen, da ${game.forfeitedBy} aufgegeben hat.`;
} else {
maxScore = Math.max(...scores);
winners = playerNames.filter((name, idx) => scores[idx] === maxScore);
winnerText = winners.length > 1
? `Unentschieden zwischen ${winners.join(' und ')}`
: `${winners[0]} hat gewonnen!`;
}
return (
<div id="game-completion-modal" className={modalStyles['modal'] + ' ' + modalStyles['show']} role="dialog" aria-modal="true" aria-labelledby="completion-modal-title">
<div className={modalStyles['modal-content']}>
<div className={modalStyles['modal-header']}>
<span className={modalStyles['modal-title']} id="completion-modal-title">Spiel beendet</span>
<button className={modalStyles['close-button']} onClick={onClose} aria-label="Schließen">×</button>
</div>
<div className={modalStyles['modal-body']}>
<div className={styles['final-scores']}>
{playerNames.map((name, idx) => (
<div className={styles['final-score']} key={name + idx}>
<span className={styles['player-name']}>{name}</span>
<span className={styles['score']}>{scores[idx]}</span>
</div>
))}
</div>
<div className={styles['winner-announcement']}><h3>{winnerText}</h3></div>
</div>
<div className={modalStyles['modal-footer']}>
<button className={styles['btn'] + ' ' + styles['btn--warning']} onClick={onConfirm} aria-label="Bestätigen">Bestätigen</button>
<button className={styles['btn'] + ' ' + styles['btn--primary']} onClick={onRematch} aria-label="Rematch">Rematch</button>
<button className={styles['btn']} onClick={onClose} aria-label="Abbrechen">Abbrechen</button>
</div>
</div>
</div>
);
};
export default GameCompletionModal;

View File

@@ -0,0 +1,30 @@
# Game Lifecycle (`@lib/features/game-lifecycle`)
Utility components that react to lifecycle transitions in a game session.
## GameCompletionModal
- Props:
- `open: boolean`
- `game: Game | null`
- `onConfirm(): void`
- `onClose(): void`
- `onRematch(): void`
- Renders final scores, winner messaging, and rematch CTA.
- Reuses `@lib/ui/Modal.module.css` for a consistent look-and-feel.
## Example
```tsx
import { GameCompletionModal } from '@lib/features/game-lifecycle';
<GameCompletionModal
open={state.open}
game={state.game}
onConfirm={finalise}
onRematch={startRematch}
onClose={closeModal}
/>;
```

View File

@@ -0,0 +1,2 @@
export { default as GameCompletionModal } from './GameCompletionModal';

View File

@@ -23,8 +23,9 @@
.game-list { .game-list {
width: 100%; width: 100%;
flex: 1; display: flex;
overflow-y: auto; flex-direction: column;
min-height: 0;
} }
/* Filter buttons with improved symmetry */ /* Filter buttons with improved symmetry */
@@ -36,6 +37,7 @@
border-radius: var(--radius-md); border-radius: var(--radius-md);
overflow: hidden; overflow: hidden;
box-shadow: var(--shadow-sm); box-shadow: var(--shadow-sm);
flex-shrink: 0;
} }
.filter-button { .filter-button {
@@ -71,6 +73,11 @@
flex-direction: column; flex-direction: column;
gap: var(--space-md); gap: var(--space-md);
margin-top: var(--space-lg); margin-top: var(--space-lg);
flex: 1;
overflow-y: auto;
overflow-x: hidden;
min-height: 0;
padding-bottom: var(--space-md);
} }
/* Game item with better symmetry and spacing */ /* Game item with better symmetry and spacing */

View File

@@ -0,0 +1,129 @@
import { h } from 'preact';
import { Card } from '@lib/ui/Card';
import { Button } from '@lib/ui/Button';
import styles from './GameList.module.css';
import type { Game, GameFilter, StandardGame } from '@lib/domain/types';
interface GameListProps {
games: Game[];
filter: GameFilter;
setFilter: (filter: GameFilter) => void;
onShowGameDetail: (gameId: number) => void;
onDeleteGame: (gameId: number) => void;
}
export default function GameList({
games,
filter = 'all',
setFilter,
onShowGameDetail,
onDeleteGame
}: GameListProps) {
const filteredGames = games
.filter(game => {
if (filter === 'active') return game.status === 'active';
if (filter === 'completed') return game.status === 'completed';
return true;
})
.sort((a, b) => new Date(b.createdAt).getTime() - new Date(a.createdAt).getTime());
const getPlayerNames = (game: Game): string => {
if ('players' in game) {
return game.players.map(p => p.name).join(' vs ');
} else {
const standardGame = game as StandardGame;
return standardGame.player3
? `${standardGame.player1} vs ${standardGame.player2} vs ${standardGame.player3}`
: `${standardGame.player1} vs ${standardGame.player2}`;
}
};
const getScores = (game: Game): string => {
if ('players' in game) {
return game.players.map(p => p.score).join(' - ');
} else {
const standardGame = game as StandardGame;
return standardGame.player3
? `${standardGame.score1} - ${standardGame.score2} - ${standardGame.score3}`
: `${standardGame.score1} - ${standardGame.score2}`;
}
};
const filterButtons = [
{ key: 'all' as const, label: 'Alle', ariaLabel: 'Alle Spiele anzeigen' },
{ key: 'active' as const, label: 'Aktiv', ariaLabel: 'Nur aktive Spiele anzeigen' },
{ key: 'completed' as const, label: 'Abgeschlossen', ariaLabel: 'Nur abgeschlossene Spiele anzeigen' },
];
return (
<div className={styles['game-list']}>
<div className={styles['filter-buttons']}>
{filterButtons.map(({ key, label, ariaLabel }) => (
<Button
key={key}
variant={filter === key ? 'primary' : 'secondary'}
size="small"
onClick={() => setFilter(key)}
aria-label={ariaLabel}
>
{label}
</Button>
))}
</div>
<div className={styles['games-container']}>
{filteredGames.length === 0 ? (
<div className={styles['empty-state']}>Keine Spiele vorhanden</div>
) : (
filteredGames.map(game => {
const playerNames = getPlayerNames(game);
const scores = getScores(game);
return (
<Card
key={game.id}
variant="elevated"
className={
styles['game-item'] + ' ' + (game.status === 'completed' ? styles['completed'] : styles['active'])
}
>
<div
className={styles['game-info']}
onClick={() => onShowGameDetail(game.id)}
onKeyDown={(e) => {
if (e.key === 'Enter' || e.key === ' ') {
e.preventDefault();
onShowGameDetail(game.id);
}
}}
role="button"
tabIndex={0}
aria-label={`Details für Spiel ${playerNames}`}
aria-describedby={`game-${game.id}-description`}
>
<div className={styles['game-type']}>
{game.gameType}{game.raceTo ? ` | ${game.raceTo}` : ''}
</div>
<div className={styles['player-names']}>{playerNames}</div>
<div className={styles['game-scores']}>{scores}</div>
<div id={`game-${game.id}-description`} className="sr-only">
{game.gameType} Spiel zwischen {playerNames} mit dem Stand {scores}.
{game.status === 'completed' ? 'Abgeschlossen' : 'Aktiv'}
</div>
</div>
<Button
variant="danger"
size="small"
onClick={() => onDeleteGame(game.id)}
aria-label={`Spiel löschen: ${playerNames}`}
>
🗑
</Button>
</Card>
);
})
)}
</div>
</div>
);
}

View File

@@ -0,0 +1,33 @@
# Game List (`@lib/features/game-list`)
Single component `GameList` renders the scoreboard overview with filter tabs.
## Props
- `games: Game[]`
- `filter: GameFilter`
- `setFilter(filter: GameFilter): void`
- `onShowGameDetail(gameId: number): void`
- `onDeleteGame(gameId: number): void`
## Behaviour
- Sorts games by `createdAt` (desc) and filters according to `filter`.
- Derives player names/scores for both `StandardGame` and `EndlosGame`.
- Uses `@lib/ui` primitives (`Button`, `Card`) for visuals.
## Example
```tsx
import { GameList } from '@lib/features/game-list';
<GameList
games={games}
filter={filter}
setFilter={setFilter}
onShowGameDetail={showDetail}
onDeleteGame={openDeleteModal}
/>;
```

View File

@@ -0,0 +1,2 @@
export { default as GameList } from './GameList';

View File

@@ -13,16 +13,18 @@
.screen-content { .screen-content {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
min-height: 100vh; height: 100%;
padding: var(--space-lg); padding: var(--space-lg);
overflow-y: auto; overflow-y: auto;
overflow-x: hidden;
-webkit-overflow-scrolling: touch; -webkit-overflow-scrolling: touch;
min-height: 0;
} }
.screen-title { .screen-title {
font-size: var(--font-size-xxl); font-size: clamp(1.25rem, 3vh, 1.5rem);
font-weight: 700; font-weight: 700;
color: var(--color-text); color: var(--color-text);
margin-bottom: var(--space-xl); margin-bottom: clamp(0.5rem, 2vh, 2rem);
letter-spacing: 0.5px; letter-spacing: 0.5px;
text-align: center; text-align: center;
} }
@@ -32,6 +34,8 @@
gap: var(--space-lg); gap: var(--space-lg);
width: 100%; width: 100%;
margin-bottom: var(--space-xl); margin-bottom: var(--space-xl);
flex-shrink: 1;
min-height: 0;
} }
.player-input { .player-input {
background: var(--color-background); background: var(--color-background);
@@ -40,6 +44,9 @@
border: 2px solid var(--color-border); border: 2px solid var(--color-border);
transition: border-color var(--transition-base); transition: border-color var(--transition-base);
position: relative; position: relative;
flex-shrink: 1;
min-height: 0;
overflow: hidden;
} }
.player-input:focus-within { .player-input:focus-within {
border-color: var(--color-primary); border-color: var(--color-primary);
@@ -47,9 +54,9 @@
} }
.player-input label { .player-input label {
display: block; display: block;
margin-bottom: var(--space-md); margin-bottom: clamp(0.5rem, 2vh, 1rem);
color: var(--color-text); color: var(--color-text);
font-size: var(--font-size-lg); font-size: clamp(1rem, 2.5vh, 1.125rem);
font-weight: 600; font-weight: 600;
} }
.name-input-container { .name-input-container {
@@ -122,22 +129,43 @@
background: var(--color-surface); background: var(--color-surface);
border-radius: var(--radius-xl); border-radius: var(--radius-xl);
box-shadow: var(--shadow-lg); box-shadow: var(--shadow-lg);
padding: var(--space-xl) var(--space-lg) var(--space-lg) var(--space-lg); padding: 0;
display: flex; display: flex;
flex-direction: column; flex-direction: column;
gap: var(--space-lg);
border: 1px solid var(--color-border); border: 1px solid var(--color-border);
flex: 1;
min-height: 0;
overflow: hidden;
}
.form-header {
flex-shrink: 0;
padding: clamp(0.5rem, 2vh, 2rem) var(--space-lg) clamp(0.25rem, 1vh, 1rem) var(--space-lg);
}
.form-content {
flex: 1;
overflow: hidden;
padding: 0 var(--space-lg);
min-height: 0;
display: flex;
flex-direction: column;
}
.form-footer {
flex-shrink: 0;
padding: var(--space-lg);
} }
.progress-indicator { .progress-indicator {
display: flex; display: flex;
justify-content: center; justify-content: center;
align-items: center; align-items: center;
gap: var(--space-md); gap: clamp(0.5rem, 1.5vw, 1rem);
margin-bottom: var(--space-lg); margin-bottom: clamp(0.5rem, 2vh, 1.5rem);
} }
.progress-dot { .progress-dot {
width: 16px; width: clamp(10px, 2vh, 16px);
height: 16px; height: clamp(10px, 2vh, 16px);
border-radius: 50%; border-radius: 50%;
background: var(--color-border); background: var(--color-border);
opacity: 0.4; opacity: 0.4;
@@ -150,18 +178,27 @@
transform: scale(1.2); transform: scale(1.2);
box-shadow: 0 0 0 4px var(--color-primary-light); box-shadow: 0 0 0 4px var(--color-primary-light);
} }
.quick-pick-container {
flex: 1;
overflow: hidden;
min-height: 0;
display: flex;
flex-direction: column;
}
.quick-pick-btn { .quick-pick-btn {
min-width: 80px; min-width: 60px;
min-height: var(--touch-target-comfortable); min-height: 36px;
font-size: var(--font-size-base); font-size: clamp(0.75rem, 2vw, 1rem);
border-radius: var(--radius-md); border-radius: var(--radius-md);
background: var(--color-secondary); background: var(--color-secondary);
color: var(--color-text); color: var(--color-text);
border: 1px solid var(--color-border); border: 1px solid var(--color-border);
cursor: pointer; cursor: pointer;
padding: var(--space-sm) var(--space-md); padding: 0.4rem 0.8rem;
transition: all var(--transition-base); transition: all var(--transition-base);
font-weight: 500; font-weight: 500;
flex-shrink: 0;
} }
.quick-pick-btn:hover, .quick-pick-btn:focus { .quick-pick-btn:hover, .quick-pick-btn:focus {
background: var(--color-secondary-hover); background: var(--color-secondary-hover);

View File

@@ -0,0 +1,31 @@
import { h } from 'preact';
import type { JSX } from 'preact';
import styles from './NewGame.module.css';
interface ProgressIndicatorProps {
currentStep: number;
totalSteps?: number;
style?: JSX.CSSProperties;
}
export function ProgressIndicator({
currentStep,
totalSteps = 7,
style,
}: ProgressIndicatorProps) {
const activeIndex = Math.min(Math.max(currentStep, 1), totalSteps) - 1;
return (
<div className={styles['progress-indicator']} style={style}>
{Array.from({ length: totalSteps }, (_, index) => {
const isActive = index === activeIndex;
const className = isActive
? `${styles['progress-dot']} ${styles['active']}`
: styles['progress-dot'];
return <span key={index} className={className} />;
})}
</div>
);
}

View File

@@ -0,0 +1,46 @@
# New Game Wizard (`@lib/features/new-game`)
Composable building blocks for the multi-step "start a new game" workflow.
## Exports
- `Player1Step`, `Player2Step`, `Player3Step` Player name capture with history + quick picks.
- `GameTypeStep` Game type selector.
- `RaceToStep` Numeric race-to chooser with infinity support.
- `BreakRuleStep`, `BreakOrderStep` Break configuration helpers.
- `PlayerSelectModal` Modal surface for long player lists.
All exports are surfaced via `@lib/features/new-game`.
## Props & Contracts
- Steps expect pure callbacks (`onNext`, `onCancel`) and derive their own UI state.
- Player history arrays control quick-pick ordering. Empty arrays fall back gracefully.
- Styling is shared via `NewGame.module.css` to keep a consistent visual language.
## Integrating the Wizard
```tsx
import { Player1Step, Player2Step } from '@lib/features/new-game';
import { useNewGameWizard } from '@lib/state';
const wizard = useNewGameWizard();
return (
<>
{wizard.newGameStep === 'player1' && (
<Player1Step
playerNameHistory={playerHistory}
onNext={(name) => {
wizard.updateGameData({ player1: name });
wizard.nextStep('player2');
}}
onCancel={wizard.resetWizard}
/>
)}
{/* render subsequent steps analogously */}
</>
);
```

View File

@@ -0,0 +1,10 @@
export { PlayerSelectModal } from './steps/PlayerSelectModal';
export { Player1Step } from './steps/Player1Step';
export { Player2Step } from './steps/Player2Step';
export { Player3Step } from './steps/Player3Step';
export { GameTypeStep } from './steps/GameTypeStep';
export { RaceToStep } from './steps/RaceToStep';
export { BreakRuleStep } from './steps/BreakRuleStep';
export { BreakOrderStep } from './steps/BreakOrderStep';
export { ProgressIndicator } from './ProgressIndicator';

View File

@@ -0,0 +1,115 @@
import { h } from 'preact';
import { useEffect, useState } from 'preact/hooks';
import styles from '../NewGame.module.css';
import { ProgressIndicator } from '../ProgressIndicator';
import type { BreakRule } from '@lib/domain/types';
interface BreakOrderStepProps {
players: string[];
rule: BreakRule;
onNext: (first: number, second?: number) => void;
onCancel: () => void;
initialFirst?: number;
initialSecond?: number;
}
export const BreakOrderStep = ({ players, rule, onNext, onCancel, initialFirst = 1, initialSecond }: BreakOrderStepProps) => {
const playerCount = players.filter(Boolean).length;
const [first, setFirst] = useState<number>(initialFirst);
const [second, setSecond] = useState<number | undefined>(initialSecond);
useEffect(() => {
if (!initialSecond && rule === 'wechselbreak' && playerCount === 3) {
setSecond(2);
}
}, [initialSecond, rule, playerCount]);
const handleFirst = (idx: number) => {
setFirst(idx);
if (rule === 'winnerbreak' || (rule === 'wechselbreak' && playerCount === 2)) {
onNext(idx);
}
};
const handleSecond = (idx: number) => {
setSecond(idx);
onNext(first, idx);
};
return (
<form className={styles['new-game-form']} aria-label="Break-Reihenfolge wählen">
<div className={styles['form-header']}>
<div className={styles['screen-title']}>Wer hat den ersten Anstoss?</div>
<ProgressIndicator currentStep={7} style={{ marginBottom: 24 }} />
</div>
<div className={styles['form-content']}>
<div style={{ marginBottom: 16, fontWeight: 600 }}>Wer hat den ersten Anstoss?</div>
<div style={{ display: 'flex', gap: 16, flexWrap: 'wrap' }}>
{players.filter(Boolean).map((name, idx) => (
<button
key={`first-${idx}`}
type="button"
className={`${styles['quick-pick-btn']} ${first === (idx + 1) ? styles['selected'] : ''}`}
onClick={() => handleFirst(idx + 1)}
aria-label={`Zuerst: ${name}`}
style={{ minWidth: 160, minHeight: 64, fontSize: '1.2rem', padding: '16px 32px' }}
>
{name}
</button>
))}
</div>
{rule === 'wechselbreak' && playerCount === 3 && (
<>
<div style={{ marginTop: 24, marginBottom: 16, fontWeight: 600 }}>Wer hat den zweiten Anstoss?</div>
<div style={{ display: 'flex', gap: 16, flexWrap: 'wrap' }}>
{players.filter(Boolean).map((name, idx) => (
<button
key={`second-${idx}`}
type="button"
className={`${styles['quick-pick-btn']} ${second === (idx + 1) ? styles['selected'] : ''}`}
onClick={() => handleSecond(idx + 1)}
aria-label={`Zweites Break: ${name}`}
style={{ minWidth: 160, minHeight: 64, fontSize: '1.2rem', padding: '16px 32px' }}
>
{name}
</button>
))}
</div>
</>
)}
</div>
<div className={styles['form-footer']}>
<div className={styles['arrow-nav']} style={{ display: 'flex', justifyContent: 'space-between', alignItems: 'center', marginTop: 48 }}>
<button type="button" className={styles['arrow-btn']} aria-label="Zurück" onClick={onCancel} style={{ fontSize: 48, width: 80, height: 80, borderRadius: '50%', background: '#222', color: '#fff', border: 'none', boxShadow: '0 2px 8px rgba(0,0,0,0.15)', cursor: 'pointer' }}>
&#8592;
</button>
<button
type="button"
className={styles['arrow-btn']}
aria-label="Weiter"
onClick={() => {
if (rule === 'wechselbreak' && playerCount === 3) {
if (first > 0 && (second ?? 0) > 0) {
handleSecond(second as number);
}
} else if (first > 0) {
onNext(first);
}
}}
disabled={
(rule === 'wechselbreak' && playerCount === 3) ? !(first > 0 && (second ?? 0) > 0) : !(first > 0)
}
style={{ fontSize: 48, width: 80, height: 80, borderRadius: '50%', background: '#222', color: '#fff', border: 'none', boxShadow: '0 2px 8px rgba(0,0,0,0.15)', cursor: 'pointer', opacity: ((rule === 'wechselbreak' && playerCount === 3) ? !(first > 0 && (second ?? 0) > 0) : !(first > 0)) ? 0.5 : 1 }}
>
&#8594;
</button>
</div>
</div>
</form>
);
};

View File

@@ -0,0 +1,60 @@
import { h } from 'preact';
import { useState } from 'preact/hooks';
import styles from '../NewGame.module.css';
import { ProgressIndicator } from '../ProgressIndicator';
import type { BreakRule } from '@lib/domain/types';
interface BreakRuleStepProps {
onNext: (rule: BreakRule) => void;
onCancel: () => void;
initialValue?: BreakRule;
}
export const BreakRuleStep = ({ onNext, onCancel, initialValue = 'winnerbreak' }: BreakRuleStepProps) => {
const [rule, setRule] = useState<BreakRule>(initialValue ?? 'winnerbreak');
return (
<form className={styles['new-game-form']} aria-label="Break-Regel wählen">
<div className={styles['form-header']}>
<div className={styles['screen-title']}>Break-Regel wählen</div>
<ProgressIndicator currentStep={6} style={{ marginBottom: 24 }} />
</div>
<div className={styles['form-content']}>
<div style={{ display: 'flex', gap: 16, flexWrap: 'wrap' }}>
{[
{ key: 'winnerbreak', label: 'Winnerbreak' },
{ key: 'wechselbreak', label: 'Wechselbreak' },
].map(opt => (
<button
key={opt.key}
type="button"
className={`${styles['quick-pick-btn']} ${rule === (opt.key as BreakRule) ? styles['selected'] : ''}`}
onClick={() => {
setRule(opt.key as BreakRule);
onNext(opt.key as BreakRule);
}}
aria-label={`Break-Regel wählen: ${opt.label}`}
style={{ minWidth: 160, minHeight: 64, fontSize: '1.2rem', padding: '16px 32px' }}
>
{opt.label}
</button>
))}
</div>
</div>
<div className={styles['form-footer']}>
<div className={styles['arrow-nav']} style={{ display: 'flex', justifyContent: 'space-between', alignItems: 'center', marginTop: 48 }}>
<button type="button" className={styles['arrow-btn']} aria-label="Zurück" onClick={onCancel} style={{ fontSize: 48, width: 80, height: 80, borderRadius: '50%', background: '#222', color: '#fff', border: 'none', boxShadow: '0 2px 8px rgba(0,0,0,0.15)', cursor: 'pointer' }}>
&#8592;
</button>
<button type="button" className={styles['arrow-btn']} aria-label="Weiter" onClick={() => onNext(rule)} style={{ fontSize: 48, width: 80, height: 80, borderRadius: '50%', background: '#222', color: '#fff', border: 'none', boxShadow: '0 2px 8px rgba(0,0,0,0.15)', cursor: 'pointer' }}>
&#8594;
</button>
</div>
</div>
</form>
);
};

View File

@@ -1,6 +1,8 @@
import { h } from 'preact'; import { h } from 'preact';
import { useState } from 'preact/hooks'; import { useState } from 'preact/hooks';
import styles from '../NewGame.module.css'; import styles from '../NewGame.module.css';
import { ProgressIndicator } from '../ProgressIndicator';
import { GAME_TYPES } from '@lib/domain/constants';
interface GameTypeStepProps { interface GameTypeStepProps {
onNext: (type: string) => void; onNext: (type: string) => void;
@@ -10,7 +12,6 @@ interface GameTypeStepProps {
export const GameTypeStep = ({ onNext, onCancel, initialValue = '' }: GameTypeStepProps) => { export const GameTypeStep = ({ onNext, onCancel, initialValue = '' }: GameTypeStepProps) => {
const [gameType, setGameType] = useState(initialValue); const [gameType, setGameType] = useState(initialValue);
const gameTypes = ['8-Ball', '9-Ball', '10-Ball'];
const handleSelect = (selectedType: string) => { const handleSelect = (selectedType: string) => {
setGameType(selectedType); setGameType(selectedType);
@@ -26,29 +27,28 @@ export const GameTypeStep = ({ onNext, onCancel, initialValue = '' }: GameTypeSt
return ( return (
<form className={styles['new-game-form']} onSubmit={handleSubmit} aria-label="Spielart auswählen"> <form className={styles['new-game-form']} onSubmit={handleSubmit} aria-label="Spielart auswählen">
<div className={styles['screen-title']}>Spielart auswählen</div> <div className={styles['form-header']}>
<div className={styles['progress-indicator']} style={{ marginBottom: 24 }}> <div className={styles['screen-title']}>Spielart auswählen</div>
<span className={styles['progress-dot']} /> <ProgressIndicator currentStep={4} style={{ marginBottom: 24 }} />
<span className={styles['progress-dot']} />
<span className={styles['progress-dot']} />
<span className={styles['progress-dot'] + ' ' + styles['active']} />
<span className={styles['progress-dot']} />
<span className={styles['progress-dot']} />
<span className={styles['progress-dot']} />
</div> </div>
<div className={styles['game-type-selection']}>
{gameTypes.map(type => ( <div className={styles['form-content']}>
<button <div className={styles['game-type-selection']}>
key={type} {GAME_TYPES.map(({ value, label }) => (
type="button" <button
className={`${styles['game-type-btn']} ${gameType === type ? styles.selected : ''}`} key={value}
onClick={() => handleSelect(type)} type="button"
> className={`${styles['game-type-btn']} ${gameType === value ? styles.selected : ''}`}
{type} onClick={() => handleSelect(value)}
</button> >
))} {label}
</button>
))}
</div>
</div> </div>
<div className={styles['arrow-nav']} style={{ display: 'flex', justifyContent: 'space-between', alignItems: 'center', marginTop: 48 }}>
<div className={styles['form-footer']}>
<div className={styles['arrow-nav']} style={{ display: 'flex', justifyContent: 'space-between', alignItems: 'center' }}>
<button <button
type="button" type="button"
className={styles['arrow-btn']} className={styles['arrow-btn']}
@@ -78,6 +78,7 @@ export const GameTypeStep = ({ onNext, onCancel, initialValue = '' }: GameTypeSt
> >
&#8594; &#8594;
</button> </button>
</div>
</div> </div>
</form> </form>
); );

View File

@@ -1,8 +1,15 @@
import { h } from 'preact'; import { h } from 'preact';
import { useEffect, useRef, useState } from 'preact/hooks'; import { useEffect, useRef, useState } from 'preact/hooks';
import styles from '../NewGame.module.css'; import styles from '../NewGame.module.css';
import { UI_CONSTANTS, ERROR_MESSAGES, ARIA_LABELS, FORM_CONFIG, ERROR_STYLES } from '../../utils/constants'; import {
UI_CONSTANTS,
ERROR_MESSAGES,
ARIA_LABELS,
FORM_CONFIG,
ERROR_STYLES,
} from '@lib/domain/constants';
import { PlayerSelectModal } from './PlayerSelectModal'; import { PlayerSelectModal } from './PlayerSelectModal';
import { ProgressIndicator } from '../ProgressIndicator';
interface PlayerStepProps { interface PlayerStepProps {
playerNameHistory: string[]; playerNameHistory: string[];
@@ -18,17 +25,6 @@ export const Player1Step = ({ playerNameHistory, onNext, onCancel, initialValue
const [isModalOpen, setIsModalOpen] = useState(false); const [isModalOpen, setIsModalOpen] = useState(false);
const inputRef = useRef<HTMLInputElement>(null); const inputRef = useRef<HTMLInputElement>(null);
useEffect(() => {
const el = inputRef.current;
if (el) {
el.focus();
const end = el.value.length;
try {
el.setSelectionRange(end, end);
} catch {}
}
}, []);
useEffect(() => { useEffect(() => {
if (!player1) { if (!player1) {
setFilteredNames(playerNameHistory); setFilteredNames(playerNameHistory);
@@ -85,17 +81,16 @@ export const Player1Step = ({ playerNameHistory, onNext, onCancel, initialValue
return ( return (
<form className={styles['new-game-form']} onSubmit={handleSubmit} aria-label="Spieler 1 Eingabe" autoComplete="off"> <form className={styles['new-game-form']} onSubmit={handleSubmit} aria-label="Spieler 1 Eingabe" autoComplete="off">
<div className={styles['screen-title']}>Name Spieler 1</div> <div className={styles['form-header']}>
<div className={styles['progress-indicator']} style={{ marginBottom: UI_CONSTANTS.MARGIN_BOTTOM_MEDIUM }}> <div className={styles['screen-title']}>Name Spieler 1</div>
<span className={styles['progress-dot'] + ' ' + styles['active']} /> <ProgressIndicator
<span className={styles['progress-dot']} /> currentStep={1}
<span className={styles['progress-dot']} /> style={{ marginBottom: UI_CONSTANTS.MARGIN_BOTTOM_MEDIUM }}
<span className={styles['progress-dot']} /> />
<span className={styles['progress-dot']} />
<span className={styles['progress-dot']} />
<span className={styles['progress-dot']} />
</div> </div>
<div className={styles['player-input'] + ' ' + styles['player1-input']} style={{ marginBottom: UI_CONSTANTS.MARGIN_BOTTOM_LARGE, position: 'relative' }}>
<div className={styles['form-content']}>
<div className={styles['player-input'] + ' ' + styles['player1-input']} style={{ marginBottom: UI_CONSTANTS.MARGIN_BOTTOM_LARGE, position: 'relative' }}>
<label htmlFor="player1-input" style={{ fontSize: UI_CONSTANTS.LABEL_FONT_SIZE, fontWeight: 600 }}>Spieler 1</label> <label htmlFor="player1-input" style={{ fontSize: UI_CONSTANTS.LABEL_FONT_SIZE, fontWeight: 600 }}>Spieler 1</label>
<div style={{ position: 'relative', width: '100%' }}> <div style={{ position: 'relative', width: '100%' }}>
<input <input
@@ -209,29 +204,25 @@ export const Player1Step = ({ playerNameHistory, onNext, onCancel, initialValue
)} )}
</div> </div>
)} )}
</div>
{error && (
<div
className={styles['validation-error']}
style={{
marginBottom: 16,
...ERROR_STYLES.CONTAINER
}}
role="alert"
aria-live="polite"
>
<span style={ERROR_STYLES.ICON}></span>
{error}
</div> </div>
)} {error && (
{isModalOpen && ( <div
<PlayerSelectModal className={styles['validation-error']}
players={playerNameHistory} style={{
onSelect={handleModalSelect} marginBottom: 16,
onClose={() => setIsModalOpen(false)} ...ERROR_STYLES.CONTAINER
/> }}
)} role="alert"
<div className={styles['arrow-nav']} style={{ display: 'flex', justifyContent: 'space-between', alignItems: 'center', marginTop: 48 }}> aria-live="polite"
>
<span style={ERROR_STYLES.ICON}></span>
{error}
</div>
)}
</div>
<div className={styles['form-footer']}>
<div className={styles['arrow-nav']} style={{ display: 'flex', justifyContent: 'space-between', alignItems: 'center' }}>
<button <button
type="button" type="button"
className={styles['arrow-btn']} className={styles['arrow-btn']}
@@ -250,7 +241,16 @@ export const Player1Step = ({ playerNameHistory, onNext, onCancel, initialValue
> >
&#8594; &#8594;
</button> </button>
</div>
</div> </div>
{isModalOpen && (
<PlayerSelectModal
players={playerNameHistory}
onSelect={handleModalSelect}
onClose={() => setIsModalOpen(false)}
/>
)}
</form> </form>
); );
}; };

View File

@@ -1,6 +1,7 @@
import { h } from 'preact'; import { h } from 'preact';
import { useEffect, useRef, useState } from 'preact/hooks'; import { useEffect, useRef, useState } from 'preact/hooks';
import styles from '../NewGame.module.css'; import styles from '../NewGame.module.css';
import { ProgressIndicator } from '../ProgressIndicator';
interface PlayerStepProps { interface PlayerStepProps {
playerNameHistory: string[]; playerNameHistory: string[];
@@ -15,17 +16,6 @@ export const Player2Step = ({ playerNameHistory, onNext, onCancel, initialValue
const [filteredNames, setFilteredNames] = useState(playerNameHistory); const [filteredNames, setFilteredNames] = useState(playerNameHistory);
const inputRef = useRef<HTMLInputElement>(null); const inputRef = useRef<HTMLInputElement>(null);
useEffect(() => {
const el = inputRef.current;
if (el) {
el.focus();
const end = el.value.length;
try {
el.setSelectionRange(end, end);
} catch {}
}
}, []);
useEffect(() => { useEffect(() => {
if (!player2) { if (!player2) {
setFilteredNames(playerNameHistory); setFilteredNames(playerNameHistory);
@@ -61,17 +51,13 @@ export const Player2Step = ({ playerNameHistory, onNext, onCancel, initialValue
return ( return (
<form className={styles['new-game-form']} onSubmit={handleSubmit} aria-label="Spieler 2 Eingabe" autoComplete="off"> <form className={styles['new-game-form']} onSubmit={handleSubmit} aria-label="Spieler 2 Eingabe" autoComplete="off">
<div className={styles['screen-title']}>Name Spieler 2</div> <div className={styles['form-header']}>
<div className={styles['progress-indicator']} style={{ marginBottom: 24 }}> <div className={styles['screen-title']}>Name Spieler 2</div>
<span className={styles['progress-dot']} /> <ProgressIndicator currentStep={2} style={{ marginBottom: 24 }} />
<span className={styles['progress-dot'] + ' ' + styles['active']} />
<span className={styles['progress-dot']} />
<span className={styles['progress-dot']} />
<span className={styles['progress-dot']} />
<span className={styles['progress-dot']} />
<span className={styles['progress-dot']} />
</div> </div>
<div className={styles['player-input'] + ' ' + styles['player2-input']} style={{ marginBottom: 32, position: 'relative' }}>
<div className={styles['form-content']}>
<div className={styles['player-input'] + ' ' + styles['player2-input']} style={{ marginBottom: 32, position: 'relative' }}>
<label htmlFor="player2-input" style={{ fontSize: '1.3rem', fontWeight: 600 }}>Spieler 2</label> <label htmlFor="player2-input" style={{ fontSize: '1.3rem', fontWeight: 600 }}>Spieler 2</label>
<div style={{ position: 'relative', width: '100%' }}> <div style={{ position: 'relative', width: '100%' }}>
<input <input
@@ -129,27 +115,31 @@ export const Player2Step = ({ playerNameHistory, onNext, onCancel, initialValue
))} ))}
</div> </div>
)} )}
</div>
{error && <div className={styles['validation-error']} style={{ marginBottom: 16 }}>{error}</div>}
</div> </div>
{error && <div className={styles['validation-error']} style={{ marginBottom: 16 }}>{error}</div>}
<div className={styles['arrow-nav']} style={{ display: 'flex', justifyContent: 'space-between', alignItems: 'center', marginTop: 48 }}> <div className={styles['form-footer']}>
<button <div className={styles['arrow-nav']} style={{ display: 'flex', justifyContent: 'space-between', alignItems: 'center' }}>
type="button" <button
className={styles['arrow-btn']} type="button"
aria-label="Zurück" className={styles['arrow-btn']}
onClick={onCancel} aria-label="Zurück"
style={{ fontSize: 48, width: 80, height: 80, borderRadius: '50%', background: '#222', color: '#fff', border: 'none', boxShadow: '0 2px 8px rgba(0,0,0,0.15)', cursor: 'pointer' }} onClick={onCancel}
> style={{ fontSize: 48, width: 80, height: 80, borderRadius: '50%', background: '#222', color: '#fff', border: 'none', boxShadow: '0 2px 8px rgba(0,0,0,0.15)', cursor: 'pointer' }}
&#8592; >
</button> &#8592;
<button </button>
type="submit" <button
className={styles['arrow-btn']} type="submit"
aria-label="Weiter" className={styles['arrow-btn']}
disabled={!player2.trim()} aria-label="Weiter"
style={{ fontSize: 48, width: 80, height: 80, borderRadius: '50%', background: '#222', color: '#fff', border: 'none', boxShadow: '0 2px 8px rgba(0,0,0,0.15)', cursor: 'pointer', opacity: !player2.trim() ? 0.5 : 1 }} disabled={!player2.trim()}
> style={{ fontSize: 48, width: 80, height: 80, borderRadius: '50%', background: '#222', color: '#fff', border: 'none', boxShadow: '0 2px 8px rgba(0,0,0,0.15)', cursor: 'pointer', opacity: !player2.trim() ? 0.5 : 1 }}
&#8594; >
</button> &#8594;
</button>
</div>
</div> </div>
</form> </form>
); );

View File

@@ -1,6 +1,7 @@
import { h } from 'preact'; import { h } from 'preact';
import { useEffect, useRef, useState } from 'preact/hooks'; import { useEffect, useRef, useState } from 'preact/hooks';
import styles from '../NewGame.module.css'; import styles from '../NewGame.module.css';
import { ProgressIndicator } from '../ProgressIndicator';
interface PlayerStepProps { interface PlayerStepProps {
playerNameHistory: string[]; playerNameHistory: string[];
@@ -14,17 +15,6 @@ export const Player3Step = ({ playerNameHistory, onNext, onCancel, initialValue
const [filteredNames, setFilteredNames] = useState(playerNameHistory); const [filteredNames, setFilteredNames] = useState(playerNameHistory);
const inputRef = useRef<HTMLInputElement>(null); const inputRef = useRef<HTMLInputElement>(null);
useEffect(() => {
const el = inputRef.current;
if (el) {
el.focus();
const end = el.value.length;
try {
el.setSelectionRange(end, end);
} catch {}
}
}, []);
useEffect(() => { useEffect(() => {
if (!player3) { if (!player3) {
setFilteredNames(playerNameHistory); setFilteredNames(playerNameHistory);
@@ -58,17 +48,13 @@ export const Player3Step = ({ playerNameHistory, onNext, onCancel, initialValue
return ( return (
<form className={styles['new-game-form']} onSubmit={handleSubmit} aria-label="Spieler 3 Eingabe" autoComplete="off"> <form className={styles['new-game-form']} onSubmit={handleSubmit} aria-label="Spieler 3 Eingabe" autoComplete="off">
<div className={styles['screen-title']}>Name Spieler 3 (optional)</div> <div className={styles['form-header']}>
<div className={styles['progress-indicator']} style={{ marginBottom: 24 }}> <div className={styles['screen-title']}>Name Spieler 3 (optional)</div>
<span className={styles['progress-dot']} /> <ProgressIndicator currentStep={3} style={{ marginBottom: 24 }} />
<span className={styles['progress-dot']} />
<span className={styles['progress-dot'] + ' ' + styles['active']} />
<span className={styles['progress-dot']} />
<span className={styles['progress-dot']} />
<span className={styles['progress-dot']} />
<span className={styles['progress-dot']} />
</div> </div>
<div className={styles['player-input'] + ' ' + styles['player3-input']} style={{ marginBottom: 32, position: 'relative' }}>
<div className={styles['form-content']}>
<div className={styles['player-input'] + ' ' + styles['player3-input']} style={{ marginBottom: 32, position: 'relative' }}>
<label htmlFor="player3-input" style={{ fontSize: '1.3rem', fontWeight: 600 }}>Spieler 3 (optional)</label> <label htmlFor="player3-input" style={{ fontSize: '1.3rem', fontWeight: 600 }}>Spieler 3 (optional)</label>
<div style={{ position: 'relative', width: '100%' }}> <div style={{ position: 'relative', width: '100%' }}>
<input <input
@@ -126,35 +112,39 @@ export const Player3Step = ({ playerNameHistory, onNext, onCancel, initialValue
))} ))}
</div> </div>
)} )}
</div>
</div> </div>
<div className={styles['arrow-nav']} style={{ display: 'flex', justifyContent: 'space-between', alignItems: 'center', marginTop: 48 }}>
<button <div className={styles['form-footer']}>
type="button" <div className={styles['arrow-nav']} style={{ display: 'flex', justifyContent: 'space-between', alignItems: 'center' }}>
className={styles['arrow-btn']}
aria-label="Zurück"
onClick={onCancel}
style={{ fontSize: 48, width: 80, height: 80, borderRadius: '50%', background: '#222', color: '#fff', border: 'none', boxShadow: '0 2px 8px rgba(0,0,0,0.15)', cursor: 'pointer' }}
>
&#8592;
</button>
<div style={{ display: 'flex', alignItems: 'center', gap: '16px' }}>
<button <button
type="button" type="button"
onClick={handleSkip}
className={styles['quick-pick-btn']}
style={{ fontSize: '1.1rem', padding: '12px 20px', borderRadius: 8, background: '#333', color: '#fff', border: 'none', cursor: 'pointer' }}
>
Überspringen
</button>
<button
type="submit"
className={styles['arrow-btn']} className={styles['arrow-btn']}
aria-label="Weiter" aria-label="Zurück"
disabled={!player3.trim()} onClick={onCancel}
style={{ fontSize: 48, width: 80, height: 80, borderRadius: '50%', background: '#222', color: '#fff', border: 'none', boxShadow: '0 2px 8px rgba(0,0,0,0.15)', cursor: 'pointer', opacity: !player3.trim() ? 0.5 : 1 }} style={{ fontSize: 48, width: 80, height: 80, borderRadius: '50%', background: '#222', color: '#fff', border: 'none', boxShadow: '0 2px 8px rgba(0,0,0,0.15)', cursor: 'pointer' }}
> >
&#8594; &#8592;
</button> </button>
<div style={{ display: 'flex', alignItems: 'center', gap: '16px' }}>
<button
type="button"
onClick={handleSkip}
className={styles['quick-pick-btn']}
style={{ fontSize: '1.1rem', padding: '12px 20px', borderRadius: 8, background: '#333', color: '#fff', border: 'none', cursor: 'pointer' }}
>
Überspringen
</button>
<button
type="submit"
className={styles['arrow-btn']}
aria-label="Weiter"
disabled={!player3.trim()}
style={{ fontSize: 48, width: 80, height: 80, borderRadius: '50%', background: '#222', color: '#fff', border: 'none', boxShadow: '0 2px 8px rgba(0,0,0,0.15)', cursor: 'pointer', opacity: !player3.trim() ? 0.5 : 1 }}
>
&#8594;
</button>
</div>
</div> </div>
</div> </div>
</form> </form>

View File

@@ -1,6 +1,12 @@
import { h } from 'preact'; import { h } from 'preact';
import { useEffect, useState } from 'preact/hooks'; import { useEffect, useState } from 'preact/hooks';
import styles from '../NewGame.module.css'; import styles from '../NewGame.module.css';
import { ProgressIndicator } from '../ProgressIndicator';
import {
RACE_TO_QUICK_PICKS,
RACE_TO_DEFAULT,
RACE_TO_INFINITY,
} from '@lib/domain/constants';
interface RaceToStepProps { interface RaceToStepProps {
onNext: (raceTo: string | number) => void; onNext: (raceTo: string | number) => void;
@@ -10,23 +16,25 @@ interface RaceToStepProps {
} }
export const RaceToStep = ({ onNext, onCancel, initialValue = '', gameType }: RaceToStepProps) => { export const RaceToStep = ({ onNext, onCancel, initialValue = '', gameType }: RaceToStepProps) => {
const quickPicks = [1, 2, 3, 4, 5, 6, 7, 8, 9]; const quickPicks = [...RACE_TO_QUICK_PICKS];
const defaultValue = 5; const defaultValue = RACE_TO_DEFAULT;
const [raceTo, setRaceTo] = useState<string | number>(initialValue !== '' ? initialValue : defaultValue); const [raceTo, setRaceTo] = useState<string | number>(
initialValue !== '' ? initialValue : defaultValue
);
useEffect(() => { useEffect(() => {
if ((initialValue === '' || initialValue === undefined) && raceTo !== defaultValue) { if (initialValue === '' || initialValue === undefined) {
setRaceTo(defaultValue); setRaceTo(defaultValue);
} } else {
if (initialValue !== '' && initialValue !== undefined && initialValue !== raceTo) {
setRaceTo(initialValue); setRaceTo(initialValue);
} }
}, [gameType, initialValue, defaultValue]); }, [defaultValue, initialValue, gameType]);
const handleQuickPick = (value: number) => { const handleQuickPick = (value: number | typeof RACE_TO_INFINITY) => {
const selected = value === 0 ? 'Infinity' : value; const selected = value === RACE_TO_INFINITY ? RACE_TO_INFINITY : value;
setRaceTo(selected); setRaceTo(selected);
const raceToValue = selected === 'Infinity' ? Infinity : (parseInt(String(selected), 10) || 0); const raceToValue =
selected === RACE_TO_INFINITY ? Infinity : parseInt(String(selected), 10) || 0;
onNext(raceToValue); onNext(raceToValue);
}; };
@@ -44,20 +52,14 @@ export const RaceToStep = ({ onNext, onCancel, initialValue = '', gameType }: Ra
return ( return (
<form className={styles['new-game-form']} onSubmit={handleSubmit} aria-label="Race To auswählen"> <form className={styles['new-game-form']} onSubmit={handleSubmit} aria-label="Race To auswählen">
<div className={styles['screen-title']}>Race To auswählen</div> <div className={styles['screen-title']}>Race To auswählen</div>
<div className={styles['progress-indicator']} style={{ marginBottom: 24 }}> <ProgressIndicator currentStep={5} style={{ marginBottom: 24 }} />
<span className={styles['progress-dot']} />
<span className={styles['progress-dot']} />
<span className={styles['progress-dot']} />
<span className={styles['progress-dot']} />
<span className={styles['progress-dot'] + ' ' + styles['active']} />
<span className={styles['progress-dot']} />
<span className={styles['progress-dot']} />
</div>
<div className={styles['endlos-container']}> <div className={styles['endlos-container']}>
<button <button
type="button" type="button"
className={`${styles['race-to-btn']} ${styles['endlos-btn']} ${raceTo === 'Infinity' ? styles.selected : ''}`} className={`${styles['race-to-btn']} ${styles['endlos-btn']} ${
onClick={() => handleQuickPick(0)} raceTo === RACE_TO_INFINITY ? styles.selected : ''
}`}
onClick={() => handleQuickPick(RACE_TO_INFINITY)}
> >
Endlos Endlos
</button> </button>
@@ -67,8 +69,10 @@ export const RaceToStep = ({ onNext, onCancel, initialValue = '', gameType }: Ra
<button <button
key={value} key={value}
type="button" type="button"
className={`${styles['race-to-btn']} ${parseInt(String(raceTo), 10) === value ? styles.selected : ''}`} className={`${styles['race-to-btn']} ${
onClick={() => handleQuickPick(value)} parseInt(String(raceTo), 10) === value ? styles.selected : ''
}`}
onClick={() => handleQuickPick(value)}
> >
{value} {value}
</button> </button>

9
src/lib/index.ts Normal file
View File

@@ -0,0 +1,9 @@
export * from './domain';
export * from './data';
export * from './state';
export * from './ui';
export * from './features/game-list';
export * from './features/game-detail';
export * from './features/game-lifecycle';
export * from './features/new-game';

38
src/lib/state/README.md Normal file
View File

@@ -0,0 +1,38 @@
# State Layer (`@lib/state`)
Compose domain + data layers into reusable hooks. Hooks are Preact-friendly but React-compatible thanks to the astro-preact compat flag.
## Hooks
- `useGameState`
- Loads/synchronises game collections.
- Exposes CRUD ops (`addGame`, `updateGame`, `deleteGame`), filtering helpers, and cached player history.
- Handles persistence errors and loading states.
- `useNavigation`
- Simple screen router for the 3 major views (list, new game, detail).
- Tracks selected game id.
- `useNewGameWizard`
- Holds transient wizard form state and immutable steps.
- Provides `startWizard`, `resetWizard`, `updateGameData`, `nextStep`.
- `useModal`, `useValidationModal`, `useCompletionModal`
- Encapsulate modal visibility state, ensuring consistent APIs across components.
## Usage
```ts
import { useGameState, useNavigation, useModal } from '@lib/state';
const gameState = useGameState();
const navigation = useNavigation();
const modal = useModal();
// gameState.games, navigation.screen, modal.openModal(), ...
```
## Design Notes
- Hooks avoid direct DOM work—UI components receive ready-to-render props and callbacks.
- Side effects (storage, logging) are delegated to `@lib/data`.
- All exports are re-exported via `@lib/state/index.ts`.

8
src/lib/state/index.ts Normal file
View File

@@ -0,0 +1,8 @@
export { useGameState } from './useGameState';
export {
useModal,
useValidationModal,
useCompletionModal,
} from './useModal';
export { useNavigation, useNewGameWizard } from './useNavigation';

View File

@@ -0,0 +1,121 @@
import { useState, useEffect, useCallback } from 'preact/hooks';
import type { Game, NewGameData, GameFilter } from '@lib/domain/types';
import { GameService } from '@lib/data/gameService';
export function useGameState() {
const [games, setGames] = useState<Game[]>([]);
const [filter, setFilter] = useState<GameFilter>('all');
const [loading, setLoading] = useState(true);
const [error, setError] = useState<string | null>(null);
// Load games from IndexedDB on mount
useEffect(() => {
const loadGames = async () => {
try {
setLoading(true);
setError(null);
const savedGames = await GameService.loadGames();
setGames(savedGames);
} catch (err) {
console.error('Failed to load games:', err);
setError('Failed to load games from storage');
} finally {
setLoading(false);
}
};
loadGames();
}, []);
const addGame = useCallback(async (gameData: NewGameData): Promise<number> => {
try {
const newGame = GameService.createGame(gameData);
await GameService.saveGame(newGame);
setGames(prevGames => [newGame, ...prevGames]);
return newGame.id;
} catch (err) {
console.error('Failed to add game:', err);
setError('Failed to save new game');
throw err;
}
}, []);
const updateGame = useCallback(async (gameId: number, updatedGame: Game) => {
try {
await GameService.saveGame(updatedGame);
setGames(prevGames =>
prevGames.map(game => game.id === gameId ? updatedGame : game)
);
} catch (err) {
console.error('Failed to update game:', err);
setError('Failed to save game changes');
throw err;
}
}, []);
const deleteGame = useCallback(async (gameId: number) => {
try {
await GameService.deleteGame(gameId);
setGames(prevGames => prevGames.filter(game => game.id !== gameId));
} catch (err) {
console.error('Failed to delete game:', err);
setError('Failed to delete game');
throw err;
}
}, []);
const getGameById = useCallback((gameId: number): Game | undefined => {
return games.find(game => game.id === gameId);
}, [games]);
const getFilteredGames = useCallback(async (): Promise<Game[]> => {
try {
return await GameService.getGamesByFilter(filter);
} catch (err) {
console.error('Failed to get filtered games:', err);
setError('Failed to load filtered games');
return games.filter(game => {
if (filter === 'active') return game.status === 'active';
if (filter === 'completed') return game.status === 'completed';
return true;
});
}
}, [filter, games]);
const getPlayerNameHistory = useCallback((): string[] => {
// Extract player names from current games for immediate UI use
const nameLastUsed: Record<string, number> = {};
games.forEach(game => {
const timestamp = new Date(game.updatedAt).getTime();
if ('players' in game) {
// EndlosGame
game.players.forEach(player => {
nameLastUsed[player.name] = Math.max(nameLastUsed[player.name] || 0, timestamp);
});
} else {
// StandardGame
if (game.player1) nameLastUsed[game.player1] = Math.max(nameLastUsed[game.player1] || 0, timestamp);
if (game.player2) nameLastUsed[game.player2] = Math.max(nameLastUsed[game.player2] || 0, timestamp);
if (game.player3) nameLastUsed[game.player3] = Math.max(nameLastUsed[game.player3] || 0, timestamp);
}
});
return [...new Set(Object.keys(nameLastUsed))].sort((a, b) => nameLastUsed[b] - nameLastUsed[a]);
}, [games]);
return {
games,
filter,
setFilter,
loading,
error,
addGame,
updateGame,
deleteGame,
getGameById,
getFilteredGames,
getPlayerNameHistory,
};
}

60
src/lib/state/useModal.ts Normal file
View File

@@ -0,0 +1,60 @@
import { useState, useCallback } from 'preact/hooks';
import type { ModalState, ValidationState, CompletionModalState } from '@lib/ui/types';
import type { Game } from '@lib/domain/types';
export function useModal() {
const [modal, setModal] = useState<ModalState>({ open: false, gameId: null });
const openModal = useCallback((gameId?: number) => {
setModal({ open: true, gameId });
}, []);
const closeModal = useCallback(() => {
setModal({ open: false, gameId: null });
}, []);
return {
modal,
openModal,
closeModal,
};
}
export function useValidationModal() {
const [validation, setValidation] = useState<ValidationState>({ open: false, message: '' });
const showValidation = useCallback((message: string) => {
setValidation({ open: true, message });
}, []);
const closeValidation = useCallback(() => {
setValidation({ open: false, message: '' });
}, []);
return {
validation,
showValidation,
closeValidation,
};
}
export function useCompletionModal() {
const [completionModal, setCompletionModal] = useState<CompletionModalState>({
open: false,
game: null
});
const openCompletionModal = useCallback((game: Game) => {
setCompletionModal({ open: true, game });
}, []);
const closeCompletionModal = useCallback(() => {
setCompletionModal({ open: false, game: null });
}, []);
return {
completionModal,
openCompletionModal,
closeCompletionModal,
};
}

View File

@@ -0,0 +1,82 @@
import { useState, useCallback } from 'preact/hooks';
import type { NewGameStep, NewGameData } from '@lib/domain/types';
type Screen = 'game-list' | 'new-game' | 'game-detail';
export function useNavigation() {
const [screen, setScreen] = useState<Screen>('game-list');
const [currentGameId, setCurrentGameId] = useState<number | null>(null);
const showGameList = useCallback(() => {
setScreen('game-list');
setCurrentGameId(null);
}, []);
const showNewGame = useCallback(() => {
setScreen('new-game');
setCurrentGameId(null);
}, []);
const showGameDetail = useCallback((gameId: number) => {
setCurrentGameId(gameId);
setScreen('game-detail');
}, []);
return {
screen,
currentGameId,
showGameList,
showNewGame,
showGameDetail,
};
}
export function useNewGameWizard() {
const [newGameStep, setNewGameStep] = useState<NewGameStep>(null);
const [newGameData, setNewGameData] = useState<NewGameData>({
player1: '',
player2: '',
player3: '',
gameType: '',
raceTo: '',
});
const startWizard = useCallback(() => {
setNewGameStep('player1');
setNewGameData({
player1: '',
player2: '',
player3: '',
gameType: '',
raceTo: '',
});
}, []);
const resetWizard = useCallback(() => {
setNewGameStep(null);
setNewGameData({
player1: '',
player2: '',
player3: '',
gameType: '',
raceTo: '',
});
}, []);
const updateGameData = useCallback((data: Partial<NewGameData>) => {
setNewGameData(prev => ({ ...prev, ...data }));
}, []);
const nextStep = useCallback((step: NewGameStep) => {
setNewGameStep(step);
}, []);
return {
newGameStep,
newGameData,
startWizard,
resetWizard,
updateGameData,
nextStep,
};
}

32
src/lib/ui/Button.tsx Normal file
View File

@@ -0,0 +1,32 @@
import { h } from 'preact';
import type { ButtonProps } from '@lib/ui/types';
import styles from './Button.module.css';
export function Button({
variant = 'secondary',
size = 'medium',
disabled = false,
children,
onClick,
'aria-label': ariaLabel,
...rest
}: ButtonProps) {
const classNames = [
styles.button,
styles[variant],
styles[size],
disabled && styles.disabled,
].filter(Boolean).join(' ');
return (
<button
className={classNames}
onClick={onClick}
disabled={disabled}
aria-label={ariaLabel}
{...rest}
>
{children}
</button>
);
}

View File

@@ -1,5 +1,6 @@
.layout { .layout {
min-height: 100vh; height: 100vh;
overflow: hidden;
background-color: var(--color-background); background-color: var(--color-background);
color: var(--color-text); color: var(--color-text);
display: flex; display: flex;
@@ -12,13 +13,19 @@
margin: 0 auto; margin: 0 auto;
padding: var(--space-md); padding: var(--space-md);
width: 100%; width: 100%;
display: flex;
flex-direction: column;
overflow: hidden;
min-height: 0;
} }
.screen { .screen {
width: 100%; width: 100%;
min-height: 100vh; height: 100%;
display: flex; display: flex;
flex-direction: column; flex-direction: column;
overflow: hidden;
min-height: 0;
} }
/* Tablet optimizations */ /* Tablet optimizations */

35
src/lib/ui/README.md Normal file
View File

@@ -0,0 +1,35 @@
# UI Primitives (`@lib/ui`)
Reusable presentation components with co-located CSS modules. No business logic; just view concerns.
## Components
- `Button` Variant + size aware button with shared styling.
- `Card` Basic container with optional elevated/outlined variants.
- `Layout` / `Screen` Page chrome primitives used by the Astro shell.
- `Modal` Generic confirmation modal (title, message, confirm/cancel).
- `ValidationModal` Specialized modal for validation feedback.
## Types
- `types.ts` defines `ButtonProps`, modal state types, etc. Re-exported via `@lib/ui`.
## Usage
```tsx
import { Button, Card, Layout } from '@lib/ui';
<Layout>
<Card variant="elevated">
<Button variant="primary">Start</Button>
</Card>
</Layout>
```
## Styling
- Each component ships with a `.module.css` file.
Astro/Vite handles module scoping automatically—consumers simply import the component.
- Custom class names can be injected through the exposed `className` props when required.

7
src/lib/ui/index.ts Normal file
View File

@@ -0,0 +1,7 @@
export * from './types';
export { Button } from './Button';
export { Card } from './Card';
export { Layout, Screen } from './Layout';
export { default as Modal } from './Modal';
export { default as ValidationModal } from './ValidationModal';

View File

@@ -85,11 +85,15 @@
} }
} }
html, body {
height: 100%;
overflow: hidden;
}
body { body {
font-family: 'Inter', -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, sans-serif; font-family: 'Inter', -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, sans-serif;
background-color: var(--color-background); background-color: var(--color-background);
color: var(--color-text); color: var(--color-text);
min-height: 100vh;
overscroll-behavior: none; overscroll-behavior: none;
line-height: 1.5; line-height: 1.5;
-webkit-font-smoothing: antialiased; -webkit-font-smoothing: antialiased;

View File

@@ -10,6 +10,11 @@
"compilerOptions": { "compilerOptions": {
"jsx": "react-jsx", "jsx": "react-jsx",
"jsxImportSource": "preact", "jsxImportSource": "preact",
"lib": ["ES2020", "DOM", "DOM.Iterable"] "lib": ["ES2020", "DOM", "DOM.Iterable"],
"baseUrl": ".",
"paths": {
"@/*": ["src/*"],
"@lib/*": ["src/lib/*"]
}
} }
} }